You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by "James Dyer (Jira)" <ji...@apache.org> on 2024/12/23 23:46:00 UTC

[jira] [Reopened] (SOLR-17541) LBSolrClient implementations should agree on 'getClient()' semantics

     [ https://issues.apache.org/jira/browse/SOLR-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Dyer reopened SOLR-17541:
-------------------------------

I have reverted PR #2899 as it was causing test failures I had not caught earlier.  It may be a little while before I am able to pick this up again some more.

> LBSolrClient implementations should agree on 'getClient()' semantics 
> ---------------------------------------------------------------------
>
>                 Key: SOLR-17541
>                 URL: https://issues.apache.org/jira/browse/SOLR-17541
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrJ
>    Affects Versions: 9.7
>            Reporter: Jason Gerlowski
>            Assignee: James Dyer
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: main (10.0)
>
>          Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> LBSolrClient has an abstract "getClient(String url)" method that is used to fetch a "Http" SolrClient appropriate for the specified URL.
> But implementations of this method differ in the client that is returned.  LBHttpSolrClient returns a client that is already pointed at the specified URL and can be used without modification. But LBHttp2SolrClient returns a client with no URL altogether, that must be pointed at the right endpoint prior to use.  This is a bit messy, and complicates the calling code in LBSolrClient quite a bit.
> We should choose one of these approaches and use it for all LBSolrClient implementations.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org