You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "GehaFearless (via GitHub)" <gi...@apache.org> on 2024/01/08 11:48:22 UTC
[PR] fix: specify ambiguous meta_server_list on recovery_test [incubator-pegasus]
GehaFearless opened a new pull request, #1839:
URL: https://github.com/apache/incubator-pegasus/pull/1839
### What problem does this PR solve? <!--add issue link with summary if exists-->
Issue: https://github.com/apache/incubator-pegasus/issues/1838
match the behavior of A and B in meta_server_list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] fix: specify ambiguous meta_server_list on recovery_test [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on code in PR #1839:
URL: https://github.com/apache/incubator-pegasus/pull/1839#discussion_r1447285252
##########
src/test/function_test/recovery/test_recovery.cpp:
##########
@@ -65,6 +66,11 @@ class recovery_test : public test_util
}
public:
+ // For easier configuration modifications,
+ // select "single_master_cluster" cluster
+ // which onebox just start one master.
Review Comment:
```suggestion
// The cluster name "single_master_cluster" (see src/test/function_test/config.ini) means the
// cluster has only one meta server, while "onebox" means the cluster has 3 meta servers.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] fix: specify ambiguous meta_server_list on recovery_test [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on code in PR #1839:
URL: https://github.com/apache/incubator-pegasus/pull/1839#discussion_r1447290923
##########
src/test/function_test/utils/test_util.h:
##########
@@ -49,7 +49,8 @@ class pegasus_client;
class test_util : public ::testing::Test
{
public:
- test_util(std::map<std::string, std::string> create_envs = {});
+ test_util(std::map<std::string, std::string> create_envs = {},
+ std::string cluster_name = "onebox");
Review Comment:
```suggestion
const std::string &cluster_name = "onebox");
```
##########
src/test/function_test/utils/test_util.cpp:
##########
@@ -62,12 +62,12 @@ using std::vector;
namespace pegasus {
-test_util::test_util(map<string, string> create_envs)
+test_util::test_util(map<string, string> create_envs, std::string cluster_name)
Review Comment:
```suggestion
test_util::test_util(map<string, string> create_envs, const std::string &cluster_name)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] fix: specify ambiguous meta_server_list on recovery_test [incubator-pegasus]
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 merged PR #1839:
URL: https://github.com/apache/incubator-pegasus/pull/1839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org