You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/14 03:17:27 UTC
[GitHub] [skywalking] liuhaoXD opened a new issue #4230: server-alarm-plugin 可能存在的线程不安全问题
liuhaoXD opened a new issue #4230: server-alarm-plugin 可能存在的线程不安全问题
URL: https://github.com/apache/skywalking/issues/4230
https://github.com/apache/skywalking/blob/f9cf17be24304bdf4afef423cbb0d5e4925f668f/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java#L232
234 行的 this.moveTo 操作是线程不安全的，lock() 操作应该放在 minutes 变量声明之前，而且 233 行的 if 逻辑跟 240 行重复了
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4230: server-alarm-plugin 可能存在的线程不安全问题
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4230: server-alarm-plugin 可能存在的线程不安全问题
URL: https://github.com/apache/skywalking/issues/4230#issuecomment-573980768
Could you submit the issue in English or send a pull request to fix the issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] liuhaoXD opened a new issue #4230: potential
thread-unsafe problem in server-alarm-plugin of oap-server module
Posted by GitBox <gi...@apache.org>.
liuhaoXD opened a new issue #4230: potential thread-unsafe problem in server-alarm-plugin of oap-server module
URL: https://github.com/apache/skywalking/issues/4230
https://github.com/apache/skywalking/blob/f9cf17be24304bdf4afef423cbb0d5e4925f668f/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java#L232
* `this.moveTo()`at line 234 is thread-unsafe.
* `minutesBetween` operation should be protected by lock()
* `if` statement at line 233 is duplicate with line 240
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 closed issue #4230: potential thread-unsafe
problem in server-alarm-plugin of oap-server module
Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #4230: potential thread-unsafe problem in server-alarm-plugin of oap-server module
URL: https://github.com/apache/skywalking/issues/4230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng closed issue #4230: server-alarm-plugin 可能存在的线程不安全问题
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #4230: server-alarm-plugin 可能存在的线程不安全问题
URL: https://github.com/apache/skywalking/issues/4230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services