You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/14 16:59:14 UTC
[GitHub] [shardingsphere] codecov-commenter commented on pull request #6035: Refactor YamlSwapper interface
codecov-commenter commented on pull request #6035:
URL: https://github.com/apache/shardingsphere/pull/6035#issuecomment-643793512
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6035?src=pr&el=h1) Report
> Merging [#6035](https://codecov.io/gh/apache/shardingsphere/pull/6035?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/1708dbd407473acafe5fc4c874e6a21b87e71b42&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `74.69%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/6035?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6035 +/- ##
============================================
+ Coverage 53.08% 53.12% +0.04%
- Complexity 437 438 +1
============================================
Files 1190 1188 -2
Lines 20947 20928 -19
Branches 3770 3769 -1
============================================
- Hits 11119 11118 -1
+ Misses 9132 9112 -20
- Partials 696 698 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6035?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ation/swapper/ClusterConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6035/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItY29uZmlndXJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY2x1c3Rlci9jb25maWd1cmF0aW9uL3N3YXBwZXIvQ2x1c3RlckNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `95.65% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ation/swapper/MetricsConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6035/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1tZXRyaWNzL3NoYXJkaW5nc3BoZXJlLW1ldHJpY3MtY29uZmlndXJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbWV0cmljcy9jb25maWd1cmF0aW9uL3N3YXBwZXIvTWV0cmljc0NvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...pper/CenterRepositoryConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6035/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY2VudGVyL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY2VudGVyLWNvbmZpZ3VyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL3lhbWwvc3dhcHBlci9DZW50ZXJSZXBvc2l0b3J5Q29uZmlndXJhdGlvbllhbWxTd2FwcGVyLmphdmE=) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...figuration/DataSourceConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6035/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtY29uZmlndXJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ3VyYXRpb24vRGF0YVNvdXJjZUNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...datacenter/yaml/RuleSchemaMetaDataYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6035/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtbWV0YWRhdGFjZW50ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY29yZS9tZXRhZGF0YWNlbnRlci95YW1sL1J1bGVTY2hlbWFNZXRhRGF0YVlhbWxTd2FwcGVyLmphdmE=) | `97.36% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ule/EncryptColumnRuleConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6035/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC95YW1sL3N3YXBwZXIvcnVsZS9FbmNyeXB0Q29sdW1uUnVsZUNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `77.77% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...l/swapper/ReplicaRuleConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6035/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVwbGljYS9zaGFyZGluZ3NwaGVyZS1yZXBsaWNhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVwbGljYS95YW1sL3N3YXBwZXIvUmVwbGljYVJ1bGVDb25maWd1cmF0aW9uWWFtbFN3YXBwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ml/swapper/ShadowRuleConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6035/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYWRvdy95YW1sL3N3YXBwZXIvU2hhZG93UnVsZUNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `88.88% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...y/KeyGenerateStrategyConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6035/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy95YW1sL3N3YXBwZXIvc3RyYXRlZ3kvS2V5R2VuZXJhdGVTdHJhdGVneUNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...tegy/ShardingStrategyConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6035/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy95YW1sL3N3YXBwZXIvc3RyYXRlZ3kvU2hhcmRpbmdTdHJhdGVneUNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `97.67% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [26 more](https://codecov.io/gh/apache/shardingsphere/pull/6035/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6035?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6035?src=pr&el=footer). Last update [1708dbd...68a8116](https://codecov.io/gh/apache/shardingsphere/pull/6035?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org