You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Ben McCann <bm...@google.com> on 2011/02/01 06:06:40 UTC
Re: GXP Plugin
Thanks John. Feel free to mark the bug as closed now.
Do you know if Struts still compiles binaries nightly that I can use to
test?
Thanks,
Ben
On Mon, Jan 31, 2011 at 2:16 PM, John Lindal <li...@yahoo-inc.com> wrote:
> All the code was moved to org.apache.struts2.views.gxp, to conform to the
> project standards.
>
> But you’re right that two files are missing: struts-plugin.xml and
> InjectedObjectContainer.java
>
> I have checked these in under WW-3475. Please check the new contents of
> trunk, and let me know if this fixes it.
>
> John
>
>
>
> On 1/31/11 2:04 PM, "Ben McCann" <bm...@google.com> wrote:
>
> There's some code missing from the Subversion repository. E.g. the
> following two directories don't appear to be there:
> src/main/resources/
> src/main/java/com/google/struts/gxp/
>
>
> On Mon, Jan 31, 2011 at 1:57 PM, John Lindal <li...@yahoo-inc.com>
> wrote:
>
> If you're referring to the pom.xml for building the gxp plugin, then that
> already has the dependency mentioned in the ticket, at least in trunk.
>
> John
>
>
> On 1/31/11 1:52 PM, "Ben McCann" <bm...@google.com> wrote:
>
> Hi,
> I was wondering if someone would be able to check-in the rest of the code
> for the GXP plugin that I contributed. Only half of it got checked in
> because of some mix-up with lost paperwork or something along those lines.
> I got a software grant form signed off on by one of our VPs at which point
> everything was resolved. However, the remaining code was never checked in.
> https://issues.apache.org/jira/browse/WW-3475
>
> Thanks,
> Ben
>
>
>
>
Re: GXP Plugin
Posted by Ben McCann <bm...@google.com>.
I meant Lukasz. Sorry to typo your name :o)
On Tue, Feb 8, 2011 at 2:25 PM, Ben McCann <bm...@google.com> wrote:
> Thanks Lakasz
>
>
> On Thu, Feb 3, 2011 at 12:51 AM, Lukasz Lenart <
> lukasz.lenart@googlemail.com> wrote:
>
>> Hi,
>>
>> I've removed that nasty class and also added missing entries into
>> assembly module. Right now Gxp plugin should be included in -all.zip
>> package as well.
>>
>>
>> Regards
>> --
>> Łukasz
>> <+48606323122>+ 48 606 323 122 <+48606323122> http://www.lenart.org.pl/
>> Kapituła Javarsovia http://javarsovia.pl
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
Re: GXP Plugin
Posted by Ben McCann <bm...@google.com>.
Thanks Lakasz
On Thu, Feb 3, 2011 at 12:51 AM, Lukasz Lenart <lukasz.lenart@googlemail.com
> wrote:
> Hi,
>
> I've removed that nasty class and also added missing entries into
> assembly module. Right now Gxp plugin should be included in -all.zip
> package as well.
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 <+48606323122> http://www.lenart.org.pl/
> Kapituła Javarsovia http://javarsovia.pl
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: GXP Plugin
Posted by Lukasz Lenart <lu...@googlemail.com>.
Hi,
I've removed that nasty class and also added missing entries into
assembly module. Right now Gxp plugin should be included in -all.zip
package as well.
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia http://javarsovia.pl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: GXP Plugin
Posted by Ben McCann <bm...@google.com>.
Cool, thanks. I tested that jar out and it's working. I also wrote up a quick
intro to using the plugin on my
blog<http://www.benmccann.com/dev-blog/google-gxp-struts-2-plugin/>
.
Is this something that will be added to Maven with a 2.2.2 release?
-Ben
On Wed, Feb 2, 2011 at 5:54 PM, Maurizio Cucchiara <
maurizio.cucchiara@gmail.com> wrote:
> Sorry for the wrong link, my bad. I'm pretty sure that I copied it.
> Is that [1] what are you looking for?
>
> [1]
> https://hudson.apache.org/hudson/job/Struts2/lastBuild/org.apache.struts$struts2-gxp-plugin/
>
> On 3 February 2011 02:40, Ben McCann <bm...@google.com> wrote:
> > Ah, I wasn't aware of the change that obviated the need for
> > InjectedObjectContainer. That's a good change. That class was pretty
> hacky
> > and ugly.
> > The build link didn't work so I changed it to
> >
> https://hudson.apache.org/hudson/job/Struts2/lastBuild/org.apache.struts$struts2-assembly/
> .
> > I don't see the GXP plugin there though. I downloaded
> > struts-2.2.2-SNAPSHOT-all.zip and looked in the lib directory.
> >
> > Thanks,
> > Ben
> >
> >
> > On Mon, Jan 31, 2011 at 11:05 PM, Lukasz Lenart <
> > lukasz.lenart@googlemail.com> wrote:
> >
> >> Hi,
> >>
> >> One thing, the InjectedObjectContainer class is not needed, I've
> >> modified the GxpResult class and right now the Struts Inject mechanism
> >> will inject a Container instance into a GxpResult object and then the
> >> GxpResult can used it to inject further.
> >>
> >> Take a look on the source, there is a setter in the GxpResult class to
> >> put the Container, and on the line 94 this container is used to inject
> >> dependencies into a Gxp instance created by Gxp.getInstance().
> >>
> >>
> >> Kind regards
> >> --
> >> Łukasz
> >> <+48606323122>+ 48 606 323 122 <+48606323122> <+48606323122>
> http://www.lenart.org.pl/
> >> Kapituła Javarsovia http://javarsovia.pl
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> For additional commands, e-mail: dev-help@struts.apache.org
> >>
> >>
> >
>
>
>
> --
> Maurizio Cucchiara
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: GXP Plugin
Posted by Maurizio Cucchiara <ma...@gmail.com>.
Sorry for the wrong link, my bad. I'm pretty sure that I copied it.
Is that [1] what are you looking for?
[1] https://hudson.apache.org/hudson/job/Struts2/lastBuild/org.apache.struts$struts2-gxp-plugin/
On 3 February 2011 02:40, Ben McCann <bm...@google.com> wrote:
> Ah, I wasn't aware of the change that obviated the need for
> InjectedObjectContainer. That's a good change. That class was pretty hacky
> and ugly.
> The build link didn't work so I changed it to
> https://hudson.apache.org/hudson/job/Struts2/lastBuild/org.apache.struts$struts2-assembly/.
> I don't see the GXP plugin there though. I downloaded
> struts-2.2.2-SNAPSHOT-all.zip and looked in the lib directory.
>
> Thanks,
> Ben
>
>
> On Mon, Jan 31, 2011 at 11:05 PM, Lukasz Lenart <
> lukasz.lenart@googlemail.com> wrote:
>
>> Hi,
>>
>> One thing, the InjectedObjectContainer class is not needed, I've
>> modified the GxpResult class and right now the Struts Inject mechanism
>> will inject a Container instance into a GxpResult object and then the
>> GxpResult can used it to inject further.
>>
>> Take a look on the source, there is a setter in the GxpResult class to
>> put the Container, and on the line 94 this container is used to inject
>> dependencies into a Gxp instance created by Gxp.getInstance().
>>
>>
>> Kind regards
>> --
>> Łukasz
>> <+48606323122>+ 48 606 323 122 <+48606323122> http://www.lenart.org.pl/
>> Kapituła Javarsovia http://javarsovia.pl
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
--
Maurizio Cucchiara
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: GXP Plugin
Posted by Ben McCann <bm...@google.com>.
Ah, I wasn't aware of the change that obviated the need for
InjectedObjectContainer. That's a good change. That class was pretty hacky
and ugly.
The build link didn't work so I changed it to
https://hudson.apache.org/hudson/job/Struts2/lastBuild/org.apache.struts$struts2-assembly/.
I don't see the GXP plugin there though. I downloaded
struts-2.2.2-SNAPSHOT-all.zip and looked in the lib directory.
Thanks,
Ben
On Mon, Jan 31, 2011 at 11:05 PM, Lukasz Lenart <
lukasz.lenart@googlemail.com> wrote:
> Hi,
>
> One thing, the InjectedObjectContainer class is not needed, I've
> modified the GxpResult class and right now the Struts Inject mechanism
> will inject a Container instance into a GxpResult object and then the
> GxpResult can used it to inject further.
>
> Take a look on the source, there is a setter in the GxpResult class to
> put the Container, and on the line 94 this container is used to inject
> dependencies into a Gxp instance created by Gxp.getInstance().
>
>
> Kind regards
> --
> Łukasz
> <+48606323122>+ 48 606 323 122 <+48606323122> http://www.lenart.org.pl/
> Kapituła Javarsovia http://javarsovia.pl
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: GXP Plugin
Posted by Lukasz Lenart <lu...@googlemail.com>.
Hi,
One thing, the InjectedObjectContainer class is not needed, I've
modified the GxpResult class and right now the Struts Inject mechanism
will inject a Container instance into a GxpResult object and then the
GxpResult can used it to inject further.
Take a look on the source, there is a setter in the GxpResult class to
put the Container, and on the line 94 this container is used to inject
dependencies into a Gxp instance created by Gxp.getInstance().
Kind regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia http://javarsovia.pl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: GXP Plugin
Posted by Maurizio Cucchiara <ma...@gmail.com>.
> Do you know if Struts still compiles binaries nightly that I can use to
> test?
Started now, check it up on [1], the build process is still pending,
so you should wait until the #262 version is builded
[1] https://hudson.apache.org/hudsons/job/Struts2/lastBuild/org.apache.struts$struts2-assembly/
--
Maurizio Cucchiara
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org