[GitHub] [hive] kasakrisz commented on a change in pull request #2015: HIVE-24821: Restrict parallel edge creation for invertable RS operators

[GitBox <gi...@apache.org>]

kasakrisz commented on a change in pull request #2015:
URL: https://github.com/apache/hive/pull/2015#discussion_r583396781



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/ParallelEdgeFixer.java
##########
@@ -239,4 +251,18 @@ private String extractColumnName(ExprNodeDesc expr) {
     }
     throw new RuntimeException("unexpected mapping expression!");

Review comment:
       nit: a more specific checked exception would suit better here or just return null a later in `colMappingInverseKeys` handle the specific exception or null only.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org