You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/06 03:49:49 UTC

[GitHub] [flink] JingsongLi opened a new pull request #10452: [FLINK-15035][table-planner-blink] Introduce unknown memory setting to table in blink planner

JingsongLi opened a new pull request #10452: [FLINK-15035][table-planner-blink] Introduce unknown memory setting to table in blink planner
URL: https://github.com/apache/flink/pull/10452
 
 
   
   ## What is the purpose of the change
   
   At present, the out of the box experience of blink planner is very poor. An important reason is that the memory of slot in many environments is not enough for the default operator memory.
   We should remove this limitation.
   
   NOTE: Due to the particularity of SortMergeJoinOperator:
   - its ExternalBufferMemory is reconstructed here, which limits its maximum and minimum.
   - Fix memory overused bug.
   
   ## Brief change log
   
   After https://jira.apache.org/jira/browse/FLINK-14566
   - We can just set a memory weight, In this way, our jobs can run under any conditions.
   - Remove memory setting in tpc-ds e2e testing.
   - Remove memory setting in blink planner it-cases.
   
   ## Verifying this change
   
   This change is already covered by existing tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? JavaDocs
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services