You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tkalkirill (via GitHub)" <gi...@apache.org> on 2023/09/26 05:30:04 UTC

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2621: IGNITE-20480 Rename "org.apache.ignite.lang" in "core" module.

tkalkirill commented on code in PR #2621:
URL: https://github.com/apache/ignite-3/pull/2621#discussion_r1336639637


##########
modules/api/src/main/java/org/apache/ignite/InitParametersBuilder.java:
##########
@@ -84,7 +83,7 @@ public InitParametersBuilder cmgNodeNames(Collection<String> cmgNodeNames) {
      * @return {@code this} for chaining.
      */
     public InitParametersBuilder clusterName(String clusterName) {
-        if (StringUtils.nullOrBlank(clusterName)) {
+        if (clusterName == null || clusterName.isBlank()) {

Review Comment:
   same



##########
modules/api/src/main/java/org/apache/ignite/InitParametersBuilder.java:
##########
@@ -36,7 +35,7 @@ public class InitParametersBuilder {
      * @return {@code this} for chaining.
      */
     public InitParametersBuilder destinationNodeName(String destinationNodeName) {
-        if (StringUtils.nullOrBlank(destinationNodeName)) {
+        if (destinationNodeName == null || destinationNodeName.isBlank()) {

Review Comment:
   I prefer methods instead of inline.



##########
modules/api/src/main/java/org/apache/ignite/lang/util/IgniteNameUtils.java:
##########
@@ -34,7 +34,7 @@ private IgniteNameUtils() {
      * @return Unquoted name or name is cast to upper case. "tbl0" -&gt; "TBL0", "\"Tbl0\"" -&gt; "Tbl0".
      */
     public static String parseSimpleName(String name) {
-        if (StringUtils.nullOrEmpty(name)) {
+        if (name == null || name.isEmpty()) {

Review Comment:
   Same



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org