You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by filmaj <gi...@git.apache.org> on 2017/07/14 16:14:37 UTC
[GitHub] cordova-android pull request #395: CB-12423: make explicit JDK 1.8 or greate...
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-android/pull/395
CB-12423: make explicit JDK 1.8 or greater is needed in the README.
Lining it up with https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#installing-the-requirements
As per https://issues.apache.org/jira/browse/CB-12423
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/filmaj/cordova-android CB-12423
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/395.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #395
----
commit 76dd8613ca0f0914da9129e171653117572933f6
Author: filmaj <ma...@gmail.com>
Date: 2017-07-14T16:13:52Z
CB-12423: make explicit JDK 1.8 or greater is needed in the README.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #395: CB-12423: make explicit JDK 1.8 or greater is ne...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/395
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr&el=h1) Report
> Merging [#395](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/5917d4ef0bd773fb54bc5b232e5ed95d3a073f8b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #395 +/- ##
=======================================
Coverage 42.55% 42.55%
=======================================
Files 17 17
Lines 1678 1678
Branches 304 304
=======================================
Hits 714 714
Misses 964 964
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr&el=footer). Last update [5917d4e...76dd861](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #395: CB-12423: make explicit JDK 1.8 or greate...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/395
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #395: CB-12423: make explicit JDK 1.8 or greater is ne...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/395
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #395: CB-12423: make explicit JDK 1.8 or greater is ne...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/395
You cool with this change @infil00p ? Just making sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org