You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/10/01 06:41:09 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #5543: xcp-ng: fix vm boot options
shwstppr opened a new pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543
### Description
Use value boot option values from VM details directly similar to other hypervisor plugins instead of relying on boot properties explicitly set for `VirtualMachineTO`.
Fixes #5535
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-937541452
@sureshanaparti I've observed the same warning both before and after fix and for all types of boot options, probably this is related to the specific version of XCP, nothing related to these changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#discussion_r721047914
##########
File path: plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
##########
@@ -1441,7 +1441,8 @@ public VM createVmFromTemplate(final Connection conn, final VirtualMachineTO vmS
throw new CloudRuntimeException("Unable to finalize VM MetaData: " + vmSpec);
}
try {
- setVmBootDetails(vm, conn, vmSpec.getBootType(), vmSpec.getBootMode());
+ String bootMode = org.apache.commons.lang3.StringUtils.defaultIfEmpty(vmSpec.getDetails().get(ApiConstants.BootType.UEFI.toString()), null);
+ setVmBootDetails(vm, conn, bootMode == null ? null : ApiConstants.BootType.UEFI.toString(), bootMode);
Review comment:
@shwstppr Why boot mode is hard coded to UEFI if not specified ? Is it possible to hard-code based on any specific version of xcp-ng?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-936060527
@AlexanderKgr
- as I pointed out the templates I've used for testing were registered in 4.15.2, is that what you imply by 'from previous versions'?
- no, this is not yet merged, you can build the branch yourself and test it out. Do not wait until it gets merged since we're closing on the code freeze and we might cut the RC soon, probably by end of the week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] AlexanderKgr commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
AlexanderKgr commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-937444631
> @AlexanderKgr I did not had these issues, I highly suspect something went wrong with updating, but could be wrong since I was on centos8 instead of debian, can I ask you to test this once more next week when we have RC1 probably (keep an eye on the mailing lists), since you'll be able to properly update this with dependencie packages manager?
Sure. No problem neighbor. I am waiting for rc1 to test. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-935044666
<b>Trillian test result (tid-2324)</b>
Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45123 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5543-t2324-xcpng82.zip
Smoke tests completed. 90 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_volume_usage | `Error` | 97.15 | test_usage.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-934197377
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] AlexanderKgr commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
AlexanderKgr commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-936950451
with the version @borisstoyanov gave me
have issues updating from 4.15.3
db connection issue
reverting to previous db and 4.15.3 fixes this issue.
tried to install 2 times
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-934693295
Not yet @AlexanderKgr, will soon be merged after testing upgrading from 4.15.1/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-934082481
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-932723636
@rhtyd unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, alma8, ubuntu18, suse15, ubuntu20, rocky8, centos8`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-centos8, kvm-rocky8, kvm-alma8, kvm-ubuntu18, kvm-ubuntu20, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-932012284
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] AlexanderKgr commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
AlexanderKgr commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-936032906
> @AlexanderKgr can you please test this pr locally?
the issue happens with templates from previous versions.
can i download the nightly for test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-937547154
Hi @AlexanderKgr, Please test with RC1 packages (watch out for the announcement in the mailing list), and share the results here. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-935152492
@borisstoyanov @vladimirpetrov please advise after your tests, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-932896351
@blueorangutan test centos7 xcpng82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-937399421
<b>Trillian test result (tid-2328)</b>
Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46530 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5543-t2328-xcpng82.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov edited a comment on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
borisstoyanov edited a comment on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-937435092
@AlexanderKgr I did not had these issues, I highly suspect something went wrong with updating, but could be wrong since I was on centos8 instead of debian, can I ask you to test this once more next week when we have RC1 probably (keep an eye on the mailing lists), since you'll be able to properly update this with dependencie packages manager?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] AlexanderKgr commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
AlexanderKgr commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-934602596
> I've tested with Linux VMs on different boot types and modes and creation of VMs and stop start of VMs are working fine and as expected boot types and modes.
>
> 1. For a VM with UEFI boot type and SECURE boot mode:
> CloudStack log >>> Setting boottype=UEFI and bootmode=SECURE for VM: 61ef9b41-60a5-0b2a-b6f6-3c043c58dea
> 2. For a VM with UEFI boot type and LEGACY boot mode:
> CloudStack log >>> Setting boottype=UEFI and bootmode=LEGACY for VM: 54a76a8a-5212-3bf4-f3ed-9c829c719411
> 3. For a VM with BIOS boot type and LEGACY boot mode: (CS is not setting boot mode if the type is BIOS, hence null)
> CloudStack log >>> Setting boottype=BIOS and bootmode=null for VM: 56930ca0-1157-b010-08e6-6359a85a0bd8
>
> I think this PR needs testing with windows VM because original issue is raised for Windows VM
is this fix merged? i can test it in windows vms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-931978465
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov edited a comment on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
borisstoyanov edited a comment on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-937435092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] AlexanderKgr commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
AlexanderKgr commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-940664159
> @AlexanderKgr hope this still was in a dev-test env, selecting N to not overwrite the db properties file was right. What error did you get in logs from updating the packages? (maybe you hit an upgrade issue we can try to fix)
>
> Can you try again and report us your issues http://download.cloudstack.org/testing/nightly/latest/debian/4.16/
yes it was a dev-test env.
No errors in update but there was an issue in starting the service cloudstack-management. Will try again in the evening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-937435092
@AlexanderKgr I did not had these issue, I highly suspect some dependencies not clicking together, but could be wrong since I was on centos8 instead of debian, can I ask you to test this once more next week when we have RC1 probably (keep an eye on the mailing lists)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-934100371
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-934082332
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-931954925
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-937541452
@sureshanaparti I've observed the same warning both before and after fix and for all types of boot options, probably this is related to the specific version of XCP, nothing related to these changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-936235299
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + xcpng82) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-936234254
@blueorangutan test centos7 xcpng82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-932723570
@blueorangutan test centos7 xcpng-82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-937435092
@AlexanderKgr I did not had these issue, I highly suspect some dependencies not clicking together, but could be wrong since I was on centos8 instead of debian, can I ask you to test this once more next week when we have RC1 probably (keep an eye on the mailing lists)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-932812872
<b>Trillian test result (tid-2295)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35943 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5543-t2295-xenserver-71.zip
Smoke tests completed. 86 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 95.98 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-936141525
@AlexanderKgr I've uploaded management and common deb packages here: https://drive.google.com/drive/folders/1SLdFLWVm6gQKEedMVI7nX-16w_ZSBkle?usp=sharing
you'll have to manually deal with dependencies packages and if you're running 4.15 you'll need to register systemvm template to upgrade properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] AlexanderKgr commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
AlexanderKgr commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-935807259
> Not yet @AlexanderKgr, will soon be merged after testing upgrading from 4.15.1/2
i mean in nightly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-936200810
@AlexanderKgr @nvazquez I think this should be fine, I've created the templates with 4.15.1 and with 4.15.2 I encountered this blocker, then upgraded to this branch and was able to start my VMs once again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-936166896
Thanks @borisstoyanov
@AlexanderKgr please let us know after you finish your tests, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-936061361
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] AlexanderKgr commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
AlexanderKgr commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-936081527
> @AlexanderKgr
> - as I pointed out the templates I've used for testing were registered in 4.15.2, is that what you imply by 'from previous versions'?
> - no, this is not yet merged, you can build the branch yourself and test it out. Do not wait until it gets merged since we're closing on the code freeze and we might cut the RC soon, probably by end of the week.
From 4.15.1
Can you help with build and test? Have never done this before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] AlexanderKgr commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
AlexanderKgr commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-936151391
> @AlexanderKgr I've uploaded management and common deb packages here: https://drive.google.com/drive/folders/1SLdFLWVm6gQKEedMVI7nX-16w_ZSBkle?usp=sharing
>
> you'll have to manually deal with dependencies packages and if you're running 4.15 you'll need to register systemvm template to upgrade properly.
Thanks. I am at 4.15.2. will install it in around 3 hours
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-934139628
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-934139205
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-932723380
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-940656087
@AlexanderKgr hope this still in a dev-test env, selecting N to not overwrite the db properties file was right. What error did you get in logs from updating the packages? (maybe you hit an upgrade issue we can try to fix)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-940656087
@AlexanderKgr hope this still in a dev-test env, selecting N to not overwrite the db properties file was right. What error did you get in logs from updating the packages? (maybe you hit an upgrade issue we can try to fix)
Can you try again and report us your issues
http://download.cloudstack.org/testing/nightly/latest/debian/4.16/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-937543350
Merging based on LGTMs and test results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-934275403
@blueorangutan test centos7 xcpng82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-934245532
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#discussion_r721985625
##########
File path: plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
##########
@@ -1441,7 +1441,8 @@ public VM createVmFromTemplate(final Connection conn, final VirtualMachineTO vmS
throw new CloudRuntimeException("Unable to finalize VM MetaData: " + vmSpec);
}
try {
- setVmBootDetails(vm, conn, vmSpec.getBootType(), vmSpec.getBootMode());
+ String bootMode = org.apache.commons.lang3.StringUtils.defaultIfEmpty(vmSpec.getDetails().get(ApiConstants.BootType.UEFI.toString()), null);
+ setVmBootDetails(vm, conn, bootMode == null ? null : ApiConstants.BootType.UEFI.toString(), bootMode);
Review comment:
@sureshanaparti setVmBootDetails() is taking both bootType and bootMode params. I've changed the code a bit for more readability. Please check now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov edited a comment on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
borisstoyanov edited a comment on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-937435092
@AlexanderKgr I did not had these issues, I highly suspect some dependencies not clicking together in packages, but could be wrong since I was on centos8 instead of debian, can I ask you to test this once more next week when we have RC1 probably (keep an eye on the mailing lists), since you'll be able to properly update this with dependencie packages manager?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] AlexanderKgr commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
AlexanderKgr commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-937444631
> @AlexanderKgr I did not had these issues, I highly suspect something went wrong with updating, but could be wrong since I was on centos8 instead of debian, can I ask you to test this once more next week when we have RC1 probably (keep an eye on the mailing lists), since you'll be able to properly update this with dependencie packages manager?
Sure. No problem neighbor. I am waiting for rc1 to test. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-932896484
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xcpng82) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-931975399
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-933050089
<b>Trillian test result (tid-2303)</b>
Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49504 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5543-t2303-xcpng82.zip
Smoke tests completed. 86 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_scale_vm | `Failure` | 4.77 | test_scale_vm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-934196745
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-931954300
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-936094701
@AlexanderKgr if you're not a developer maybe it'll be hard to build it yourself, I have packages is there a location I can upload them fro you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-935986607
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-937399421
<b>Trillian test result (tid-2328)</b>
Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46530 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5543-t2328-xcpng82.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-937518530
> I was not able to reproduce this with vms deployed in 4.15.2 with UEFI (secured), then upgraded to this branch. I was able to successfully stop and start VMs with no issues.
>
> There was one warning on stopping VM, it probably does not have to do with this change?
>
> ```
> 2021-10-06 11:16:03,345 DEBUG [c.c.h.x.r.w.x.CitrixStopCommandWrapper] (DirectAgent-76:ctx-7c82b552) (logid:de9224d6) 9. The VM i-2-8-VM is in Stopping state
> 2021-10-06 11:16:03,362 WARN [c.c.h.x.r.CitrixResourceBase] (DirectAgent-76:ctx-7c82b552) (logid:de9224d6) Task failed! Task record: uuid: 998fc3ab-99cb-64a6-2550-efc27c14f830
> nameLabel: Async.VM.clean_shutdown
> nameDescription:
> allowedOperations: []
> currentOperations: {}
> created: Wed Oct 06 11:16:03 UTC 2021
> finished: Wed Oct 06 11:16:03 UTC 2021
> status: failure
> residentOn: com.xensource.xenapi.Host@d4f0371d
> progress: 1.0
> type: <none/>
> result:
> errorInfo: [VM_LACKS_FEATURE, OpaqueRef:790a1a78-38cd-4590-aca5-d981d5561cc4]
> otherConfig: {}
> subtaskOf: com.xensource.xenapi.Task@aaf13f6f
> subtasks: []
>
> 2021-10-06 11:16:03,367 DEBUG [c.c.h.x.r.CitrixResourceBase] (DirectAgent-76:ctx-7c82b552) (logid:de9224d6) Unable to shutdown VM(i-2-8-VM) with force=false on host(ac3de140-597d-4435-ad55-62044d7d2637) due to Task failed! Task record: uuid: 998fc3ab-99cb-64a6-2550-efc27c14f830
> nameLabel: Async.VM.clean_shutdown
> nameDescription:
> allowedOperations: []
> currentOperations: {}
> created: Wed Oct 06 11:16:03 UTC 2021
> finished: Wed Oct 06 11:16:03 UTC 2021
> status: failure
> residentOn: com.xensource.xenapi.Host@d4f0371d
> progress: 1.0
> type: <none/>
> result:
> errorInfo: [VM_LACKS_FEATURE, OpaqueRef:790a1a78-38cd-4590-aca5-d981d5561cc4]
> otherConfig: {}
> subtaskOf: com.xensource.xenapi.Task@aaf13f6f
> subtasks: []
>
> 2021-10-06 11:16:04,632 DEBUG [c.c.a.ApiServlet] (qtp249034932-13:ctx-f9d3d0fb) (logid:0a34122b) ===START=== 172.16.250.11 -- GET jobId=de9224d6-1812-41bc-82c4-31089104446f&command=queryAsyncJobResult&response=json
> ```
@harikrishna-patnala Have you noticed any warning while stopping VM in your tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-936024026
@AlexanderKgr can you please test this pr locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-939775263
@AlexanderKgr since the PR was merged, you can actually test ahead of RC1 using the latest/nightly builds from http://download.cloudstack.org/testing/nightly/latest/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] AlexanderKgr edited a comment on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
AlexanderKgr edited a comment on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-936950451
with the version @borisstoyanov gave me
have issues updating from 4.15.3
db connection issue
reverting to previous db and 4.15.3 fixes this issue.
tried to install 2 times
there was a new option to select
the 1st time i selected N and the 2nd i selected Y
The same error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] AlexanderKgr commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
AlexanderKgr commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-936114356
> @AlexanderKgr if you're not a developer maybe it'll be hard to build it yourself, I have packages is there a location I can upload them fro you?
I am network admin at a company and have home lab.both with cloudstack.
Upload them somewhere like gdrive one drive etc and send me the link. For debian version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] AlexanderKgr commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
AlexanderKgr commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-936478242
> @AlexanderKgr I've uploaded management and common deb packages here: https://drive.google.com/drive/folders/1SLdFLWVm6gQKEedMVI7nX-16w_ZSBkle?usp=sharing
>
> you'll have to manually deal with dependencies packages and if you're running 4.15 you'll need to register systemvm template to upgrade properly.
gdrive has sent you a msg to allow me to view files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-932723345
@blueorangutan test centos7 xenserver-71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] AlexanderKgr commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
AlexanderKgr commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-940401260
> @AlexanderKgr since the PR was merged, you can actually test ahead of RC1 using the latest/nightly builds from http://download.cloudstack.org/testing/nightly/latest/
tried to test with cloudstack-management_4.16.0.0-snapshot.20211011_xenial_all.deb but
there was this option
i selected N and it broke my installation. had to revert.
Is this option correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-931977361
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-937542788
> @sureshanaparti I've observed the same warning both before and after fix and for all types of boot options, probably this is related to the specific version of XCP, nothing related to these changes
Thanks for the confirmation @harikrishna-patnala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-935984768
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-940656087
@AlexanderKgr hope this still was in a dev-test env, selecting N to not overwrite the db properties file was right. What error did you get in logs from updating the packages? (maybe you hit an upgrade issue we can try to fix)
Can you try again and report us your issues
http://download.cloudstack.org/testing/nightly/latest/debian/4.16/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-934331673
I've tested with Linux VMs on different boot types and modes and creation of VMs and stop start of VMs are working fine and as expected boot types and modes.
1. For a VM with UEFI boot type and SECURE boot mode:
CloudStack log >>> Setting boottype=UEFI and bootmode=SECURE for VM: 61ef9b41-60a5-0b2a-b6f6-3c043c58dea
2. For a VM with UEFI boot type and LEGACY boot mode:
CloudStack log >>> Setting boottype=UEFI and bootmode=LEGACY for VM: 54a76a8a-5212-3bf4-f3ed-9c829c719411
3. For a VM with BIOS boot type and LEGACY boot mode: (CS is not setting boot mode if the type is BIOS, hence null)
CloudStack log >>> Setting boottype=BIOS and bootmode=null for VM: 56930ca0-1157-b010-08e6-6359a85a0bd8
I think this PR needs testing with windows VM because original issue is raised for Windows VM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov edited a comment on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
borisstoyanov edited a comment on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-937435092
@AlexanderKgr I did not had these issues, I highly suspect some dependencies not clicking together, but could be wrong since I was on centos8 instead of debian, can I ask you to test this once more next week when we have RC1 probably (keep an eye on the mailing lists)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-937518530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-934276776
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + xcpng82) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5543: xcp-ng: fix vm boot options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5543:
URL: https://github.com/apache/cloudstack/pull/5543#issuecomment-934196004
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 1508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org