You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@allura.apache.org by jo...@apache.org on 2013/11/20 20:48:15 UTC
git commit: [#6903] Use dateutil to parse dates from GC issues
Updated Branches:
refs/heads/cj/6903 [created] 496d263ae
[#6903] Use dateutil to parse dates from GC issues
Signed-off-by: Cory Johns <cj...@slashdotmedia.com>
Project: http://git-wip-us.apache.org/repos/asf/incubator-allura/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-allura/commit/496d263a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-allura/tree/496d263a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-allura/diff/496d263a
Branch: refs/heads/cj/6903
Commit: 496d263ae9517d80c228507ab1599e0e86947e32
Parents: c0b5573
Author: Cory Johns <cj...@slashdotmedia.com>
Authored: Wed Nov 20 19:47:48 2013 +0000
Committer: Cory Johns <cj...@slashdotmedia.com>
Committed: Wed Nov 20 19:47:48 2013 +0000
----------------------------------------------------------------------
ForgeImporters/forgeimporters/google/tracker.py | 7 ++++---
.../forgeimporters/tests/google/test_tracker.py | 10 +++++-----
2 files changed, 9 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-allura/blob/496d263a/ForgeImporters/forgeimporters/google/tracker.py
----------------------------------------------------------------------
diff --git a/ForgeImporters/forgeimporters/google/tracker.py b/ForgeImporters/forgeimporters/google/tracker.py
index 080ea90..48bfbfe 100644
--- a/ForgeImporters/forgeimporters/google/tracker.py
+++ b/ForgeImporters/forgeimporters/google/tracker.py
@@ -23,6 +23,7 @@ from formencode import validators as fev
from pylons import tmpl_context as c
from pylons import app_globals as g
from ming.orm import session, ThreadLocalORMSession
+import dateutil.parser
from tg import (
expose,
@@ -168,8 +169,8 @@ class GoogleCodeTrackerImporter(ToolImporter):
def process_fields(self, ticket, issue):
ticket.summary = issue.get_issue_summary()
ticket.status = issue.get_issue_status()
- ticket.created_date = datetime.strptime(issue.get_issue_created_date(), '%c')
- ticket.mod_date = datetime.strptime(issue.get_issue_mod_date(), '%c')
+ ticket.created_date = dateutil.parser.parse(issue.get_issue_created_date())
+ ticket.mod_date = dateutil.parser.parse(issue.get_issue_mod_date())
ticket.votes_up = issue.get_issue_stars()
ticket.votes = issue.get_issue_stars()
owner = issue.get_issue_owner()
@@ -209,7 +210,7 @@ class GoogleCodeTrackerImporter(ToolImporter):
p = ticket.discussion_thread.add_post(
text = comment.annotated_text,
ignore_security = True,
- timestamp = datetime.strptime(comment.created_date, '%c'),
+ timestamp = dateutil.parser.parse(comment.created_date),
)
p.add_multiple_attachments(comment.attachments)
http://git-wip-us.apache.org/repos/asf/incubator-allura/blob/496d263a/ForgeImporters/forgeimporters/tests/google/test_tracker.py
----------------------------------------------------------------------
diff --git a/ForgeImporters/forgeimporters/tests/google/test_tracker.py b/ForgeImporters/forgeimporters/tests/google/test_tracker.py
index 604eafd..7003e32 100644
--- a/ForgeImporters/forgeimporters/tests/google/test_tracker.py
+++ b/ForgeImporters/forgeimporters/tests/google/test_tracker.py
@@ -162,17 +162,17 @@ class TestTrackerImporter(TestCase):
get_issue_owner=lambda:'owner',
)
importer = tracker.GoogleCodeTrackerImporter()
- with mock.patch.object(tracker, 'datetime') as dt:
- dt.strptime.side_effect = lambda s,f: s
+ with mock.patch.object(tracker, 'dateutil') as dt:
+ dt.parser.parse.side_effect = lambda s: s
importer.process_fields(ticket, issue)
self.assertEqual(ticket.summary, 'summary')
self.assertEqual(ticket.description, '*Originally created by:* creator\n*Originally owned by:* owner\n\nmy *description* fool')
self.assertEqual(ticket.status, 'status')
self.assertEqual(ticket.created_date, 'created_date')
self.assertEqual(ticket.mod_date, 'mod_date')
- self.assertEqual(dt.strptime.call_args_list, [
- mock.call('created_date', '%c'),
- mock.call('mod_date', '%c'),
+ self.assertEqual(dt.parser.parse.call_args_list, [
+ mock.call('created_date'),
+ mock.call('mod_date'),
])
def test_process_labels(self):