You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "joerghoh (via GitHub)" <gi...@apache.org> on 2025/07/18 18:12:08 UTC
[PR] JCRVLT-809 read definitions for children and properties just once [jackrabbit-filevault]
joerghoh opened a new pull request, #376:
URL: https://github.com/apache/jackrabbit-filevault/pull/376
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCRVLT-809 read definitions for children and properties just once [jackrabbit-filevault]
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh commented on code in PR #376:
URL: https://github.com/apache/jackrabbit-filevault/pull/376#discussion_r2216685588
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/util/EffectiveNodeType.java:
##########
@@ -68,6 +71,8 @@ public final class EffectiveNodeType {
private EffectiveNodeType(@NotNull List<NodeType> nodeTypes) {
this.nodeTypes = nodeTypes;
Review Comment:
But then we would also need to remove ``toString()`` ... not sure how important that is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCRVLT-809 read definitions for children and properties just once [jackrabbit-filevault]
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh merged PR #376:
URL: https://github.com/apache/jackrabbit-filevault/pull/376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCRVLT-809 read definitions for children and properties just once [jackrabbit-filevault]
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh commented on code in PR #376:
URL: https://github.com/apache/jackrabbit-filevault/pull/376#discussion_r2218451901
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/util/EffectiveNodeType.java:
##########
@@ -68,6 +71,8 @@ public final class EffectiveNodeType {
private EffectiveNodeType(@NotNull List<NodeType> nodeTypes) {
this.nodeTypes = nodeTypes;
Review Comment:
@kwin Thinking again: Let's leave it in. As mentioned ``toString`` still relies on it, and the cpu/memory overhead of having it is negligible. as these objects are typically very short-lived and are thus easily GCed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCRVLT-809 read definitions for children and properties just once [jackrabbit-filevault]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #376:
URL: https://github.com/apache/jackrabbit-filevault/pull/376#discussion_r2216669981
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/util/EffectiveNodeType.java:
##########
@@ -68,6 +71,8 @@ public final class EffectiveNodeType {
private EffectiveNodeType(@NotNull List<NodeType> nodeTypes) {
this.nodeTypes = nodeTypes;
Review Comment:
I think we then no longer need nodeTypes as field of this classs. This requires refactoring of `equals` and `hashCode` to only consider propertyDefinitions/nodeDefinitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org