You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/15 09:15:33 UTC
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4320:
refactor Orchestration properties with TypedProperties class.
codecov-io commented on issue #4320: refactor Orchestration properties with TypedProperties class.
URL: https://github.com/apache/incubator-shardingsphere/pull/4320#issuecomment-586571037
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320?src=pr&el=h1) Report
> Merging [#4320](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/18e9025c179b853b3c26511f770056e9f36af75e?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `68.96%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4320 +/- ##
============================================
+ Coverage 56.52% 56.57% +0.05%
Complexity 352 352
============================================
Files 1030 1038 +8
Lines 18383 18412 +29
Branches 3347 3345 -2
============================================
+ Hits 10391 10417 +26
- Misses 7337 7340 +3
Partials 655 655
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...nstant/properties/OrchestrationPropertiesEnum.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbnN0YW50L3Byb3BlcnRpZXMvT3JjaGVzdHJhdGlvblByb3BlcnRpZXNFbnVtLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../orchestration/center/instance/ApolloInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL0Fwb2xsb0luc3RhbmNlLmphdmE=) | `54.05% <0%> (-1.51%)` | `0 <0> (ø)` | |
| [.../center/instance/wrapper/ApolloOpenApiWrapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL3dyYXBwZXIvQXBvbGxvT3BlbkFwaVdyYXBwZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/constant/properties/OrchestrationProperties.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbnN0YW50L3Byb3BlcnRpZXMvT3JjaGVzdHJhdGlvblByb3BlcnRpZXMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...tion/center/instance/CuratorZookeeperInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvQ3VyYXRvclpvb2tlZXBlckluc3RhbmNlLmphdmE=) | `40.79% <100%> (+0.47%)` | `0 <0> (ø)` | :arrow_down: |
| [...estration/center/instance/NacosConfigInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvTmFjb3NDb25maWdJbnN0YW5jZS5qYXZh) | `66.66% <100%> (+0.87%)` | `0 <0> (ø)` | :arrow_down: |
| [...rchestration/center/instance/ApolloProperties.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL0Fwb2xsb1Byb3BlcnRpZXMuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...internal/registry/ShardingOrchestrationFacade.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vaW50ZXJuYWwvcmVnaXN0cnkvU2hhcmRpbmdPcmNoZXN0cmF0aW9uRmFjYWRlLmphdmE=) | `85.1% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...estration/center/instance/NacosPropertiesEnum.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvTmFjb3NQcm9wZXJ0aWVzRW51bS5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...ation/center/instance/ZookeeperPropertiesEnum.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvWm9va2VlcGVyUHJvcGVydGllc0VudW0uamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
| ... and [12 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320?src=pr&el=footer). Last update [18e9025...7a1abcf](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services