You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by bl...@apache.org on 2019/04/04 22:24:43 UTC
[incubator-iceberg] branch master updated: Add override annotation
for test classes (#149)
This is an automated email from the ASF dual-hosted git repository.
blue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-iceberg.git
The following commit(s) were added to refs/heads/master by this push:
new a2d0b6e Add override annotation for test classes (#149)
a2d0b6e is described below
commit a2d0b6e686c9bf8b87bf13319ef81a521ad718ee
Author: John Zhuge <jz...@apache.org>
AuthorDate: Thu Apr 4 15:24:38 2019 -0700
Add override annotation for test classes (#149)
---
core/src/test/java/org/apache/iceberg/avro/TestAvroReadProjection.java | 1 +
core/src/test/java/org/apache/iceberg/avro/TestGenericAvro.java | 1 +
data/src/test/java/org/apache/iceberg/data/avro/TestGenericData.java | 1 +
.../java/org/apache/iceberg/data/avro/TestGenericReadProjection.java | 1 +
data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java | 1 +
.../java/org/apache/iceberg/data/parquet/TestGenericReadProjection.java | 1 +
.../src/test/java/org/apache/iceberg/avro/TestParquetReadProjection.java | 1 +
.../src/test/java/org/apache/iceberg/spark/data/TestSparkAvroReader.java | 1 +
.../test/java/org/apache/iceberg/spark/data/TestSparkParquetReader.java | 1 +
spark/src/test/java/org/apache/iceberg/spark/source/TestAvroScan.java | 1 +
10 files changed, 10 insertions(+)
diff --git a/core/src/test/java/org/apache/iceberg/avro/TestAvroReadProjection.java b/core/src/test/java/org/apache/iceberg/avro/TestAvroReadProjection.java
index 94b3e58..9742c1e 100644
--- a/core/src/test/java/org/apache/iceberg/avro/TestAvroReadProjection.java
+++ b/core/src/test/java/org/apache/iceberg/avro/TestAvroReadProjection.java
@@ -28,6 +28,7 @@ import org.apache.iceberg.Schema;
import org.apache.iceberg.io.FileAppender;
public class TestAvroReadProjection extends TestReadProjection {
+ @Override
protected GenericData.Record writeAndRead(String desc,
Schema writeSchema,
Schema readSchema,
diff --git a/core/src/test/java/org/apache/iceberg/avro/TestGenericAvro.java b/core/src/test/java/org/apache/iceberg/avro/TestGenericAvro.java
index bea553a..8b89fda 100644
--- a/core/src/test/java/org/apache/iceberg/avro/TestGenericAvro.java
+++ b/core/src/test/java/org/apache/iceberg/avro/TestGenericAvro.java
@@ -30,6 +30,7 @@ import org.apache.iceberg.io.FileAppender;
import org.junit.Assert;
public class TestGenericAvro extends AvroDataTest {
+ @Override
protected void writeAndValidate(Schema schema) throws IOException {
List<Record> expected = RandomAvroData.generate(schema, 100, 0L);
diff --git a/data/src/test/java/org/apache/iceberg/data/avro/TestGenericData.java b/data/src/test/java/org/apache/iceberg/data/avro/TestGenericData.java
index a752b8c..c703ff7 100644
--- a/data/src/test/java/org/apache/iceberg/data/avro/TestGenericData.java
+++ b/data/src/test/java/org/apache/iceberg/data/avro/TestGenericData.java
@@ -35,6 +35,7 @@ import org.apache.iceberg.io.FileAppender;
import org.junit.Assert;
public class TestGenericData extends DataTest {
+ @Override
protected void writeAndValidate(Schema schema) throws IOException {
List<Record> expected = RandomGenericData.generate(schema, 100, 0L);
diff --git a/data/src/test/java/org/apache/iceberg/data/avro/TestGenericReadProjection.java b/data/src/test/java/org/apache/iceberg/data/avro/TestGenericReadProjection.java
index 362af0a..cfddb2b 100644
--- a/data/src/test/java/org/apache/iceberg/data/avro/TestGenericReadProjection.java
+++ b/data/src/test/java/org/apache/iceberg/data/avro/TestGenericReadProjection.java
@@ -30,6 +30,7 @@ import org.apache.iceberg.data.TestReadProjection;
import org.apache.iceberg.io.FileAppender;
public class TestGenericReadProjection extends TestReadProjection {
+ @Override
protected Record writeAndRead(String desc, Schema writeSchema, Schema readSchema, Record record)
throws IOException {
File file = temp.newFile(desc + ".avro");
diff --git a/data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java b/data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java
index a54b7c8..05c7f9a 100644
--- a/data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java
+++ b/data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java
@@ -35,6 +35,7 @@ import org.apache.iceberg.parquet.Parquet;
import org.junit.Assert;
public class TestGenericData extends DataTest {
+ @Override
protected void writeAndValidate(Schema schema) throws IOException {
List<Record> expected = RandomGenericData.generate(schema, 100, 0L);
diff --git a/data/src/test/java/org/apache/iceberg/data/parquet/TestGenericReadProjection.java b/data/src/test/java/org/apache/iceberg/data/parquet/TestGenericReadProjection.java
index a6b3238..905073f 100644
--- a/data/src/test/java/org/apache/iceberg/data/parquet/TestGenericReadProjection.java
+++ b/data/src/test/java/org/apache/iceberg/data/parquet/TestGenericReadProjection.java
@@ -30,6 +30,7 @@ import org.apache.iceberg.io.FileAppender;
import org.apache.iceberg.parquet.Parquet;
public class TestGenericReadProjection extends TestReadProjection {
+ @Override
protected Record writeAndRead(String desc, Schema writeSchema, Schema readSchema, Record record)
throws IOException {
File file = temp.newFile(desc + ".parquet");
diff --git a/parquet/src/test/java/org/apache/iceberg/avro/TestParquetReadProjection.java b/parquet/src/test/java/org/apache/iceberg/avro/TestParquetReadProjection.java
index 70ab534..113c317 100644
--- a/parquet/src/test/java/org/apache/iceberg/avro/TestParquetReadProjection.java
+++ b/parquet/src/test/java/org/apache/iceberg/avro/TestParquetReadProjection.java
@@ -29,6 +29,7 @@ import org.apache.iceberg.io.FileAppender;
import org.apache.iceberg.parquet.Parquet;
public class TestParquetReadProjection extends TestReadProjection {
+ @Override
protected GenericData.Record writeAndRead(String desc,
Schema writeSchema,
Schema readSchema,
diff --git a/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkAvroReader.java b/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkAvroReader.java
index 2dc558b..22be131 100644
--- a/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkAvroReader.java
+++ b/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkAvroReader.java
@@ -35,6 +35,7 @@ import org.junit.Assert;
import static org.apache.iceberg.spark.data.TestHelpers.assertEqualsUnsafe;
public class TestSparkAvroReader extends AvroDataTest {
+ @Override
protected void writeAndValidate(Schema schema) throws IOException {
List<Record> expected = RandomData.generateList(schema, 100, 0L);
diff --git a/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkParquetReader.java b/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkParquetReader.java
index 58a7d84..5e22cce 100644
--- a/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkParquetReader.java
+++ b/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkParquetReader.java
@@ -38,6 +38,7 @@ import org.junit.Assume;
import static org.apache.iceberg.spark.data.TestHelpers.assertEqualsUnsafe;
public class TestSparkParquetReader extends AvroDataTest {
+ @Override
protected void writeAndValidate(Schema schema) throws IOException {
Assume.assumeTrue("Parquet Avro cannot write non-string map keys", null == TypeUtil.find(schema,
type -> type.isMapType() && type.asMapType().keyType() != Types.StringType.get()));
diff --git a/spark/src/test/java/org/apache/iceberg/spark/source/TestAvroScan.java b/spark/src/test/java/org/apache/iceberg/spark/source/TestAvroScan.java
index 8147fa1..60bedb6 100644
--- a/spark/src/test/java/org/apache/iceberg/spark/source/TestAvroScan.java
+++ b/spark/src/test/java/org/apache/iceberg/spark/source/TestAvroScan.java
@@ -68,6 +68,7 @@ public class TestAvroScan extends AvroDataTest {
spark.stop();
}
+ @Override
protected void writeAndValidate(Schema schema) throws IOException {
File parent = temp.newFolder("avro");
File location = new File(parent, "test");