You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ti...@apache.org on 2023/08/12 19:32:44 UTC
[tika] branch main updated: TIKA-4114: simplify code, add comment
This is an automated email from the ASF dual-hosted git repository.
tilman pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tika.git
The following commit(s) were added to refs/heads/main by this push:
new 81c7ca4ce TIKA-4114: simplify code, add comment
81c7ca4ce is described below
commit 81c7ca4ce06ee41fe06a14272a02b28342d014b2
Author: Tilman Hausherr <ti...@apache.org>
AuthorDate: Sat Aug 12 21:31:44 2023 +0200
TIKA-4114: simplify code, add comment
---
.../apache/tika/parser/pdf/PDFIncrementalUpdatesTest.java | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/test/java/org/apache/tika/parser/pdf/PDFIncrementalUpdatesTest.java b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/test/java/org/apache/tika/parser/pdf/PDFIncrementalUpdatesTest.java
index 7b6c88626..469d253d1 100644
--- a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/test/java/org/apache/tika/parser/pdf/PDFIncrementalUpdatesTest.java
+++ b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/test/java/org/apache/tika/parser/pdf/PDFIncrementalUpdatesTest.java
@@ -20,14 +20,13 @@ import static org.junit.jupiter.api.Assertions.assertArrayEquals;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
-import java.io.ByteArrayInputStream;
import java.io.IOException;
import java.nio.charset.StandardCharsets;
import java.util.List;
-import org.apache.pdfbox.io.MemoryUsageSetting;
+import org.apache.pdfbox.io.RandomAccessBuffer;
import org.apache.pdfbox.io.RandomAccessRead;
-import org.apache.pdfbox.io.ScratchFile;
+
import org.junit.jupiter.api.Test;
import org.apache.tika.TikaTest;
@@ -132,19 +131,14 @@ public class PDFIncrementalUpdatesTest extends TikaTest {
private List<StartXRefOffset> getOffsets(String s) throws IOException {
+ //TODO PDFBOX30 replace RandomAccessBuffer with RandomAccessReadBuffer
try (RandomAccessRead randomAccessRead =
- getRandomAccessRead(s.getBytes(StandardCharsets.US_ASCII))) {
+ new RandomAccessBuffer(s.getBytes(StandardCharsets.US_ASCII))) {
StartXRefScanner scanner = new StartXRefScanner(randomAccessRead);
return scanner.scan();
}
}
- RandomAccessRead getRandomAccessRead(byte[] bytes) throws IOException {
- MemoryUsageSetting memUsageSetting = MemoryUsageSetting.setupMainMemoryOnly();
- ScratchFile scratchFile = new ScratchFile(memUsageSetting);
- return scratchFile.createBuffer(new ByteArrayInputStream(bytes));
- }
-
@Test
public void testIncrementalUpdateParsing() throws Exception {
PDFParserConfig pdfParserConfig = new PDFParserConfig();