You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/02 14:57:04 UTC

[jira] [Commented] (KAFKA-5272) Improve validation for Describe/Alter Configs (KIP-133)

    [ https://issues.apache.org/jira/browse/KAFKA-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034818#comment-16034818 ] 

ASF GitHub Bot commented on KAFKA-5272:
---------------------------------------

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/3210

    [WIP] KAFKA-5272: Improve validation for Describe/Alter Configs (KIP-133)

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka kafka-5272-improve-validation-for-describe-alter-configs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3210
    
----
commit a944c7b5727ebddec940cbed0ca1622b4f0b4016
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-06-01T23:21:56Z

    KAFKA-5272: Add AlterConfigPolicy

----


> Improve validation for Describe/Alter Configs (KIP-133)
> -------------------------------------------------------
>
>                 Key: KAFKA-5272
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5272
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Ismael Juma
>            Assignee: Ismael Juma
>             Fix For: 0.11.0.0
>
>
> TopicConfigHandler.processConfigChanges() warns about certain topic configs. We should include such validations in alter configs and reject the change if the validation fails. Note that this should be done without changing the behaviour of the ConfigCommand (as it does not have access to the broker configs).
> We should consider adding other validations like KAFKA-4092 and KAFKA-4680.
> Finally, the AlterConfigsPolicy mentioned in KIP-133 will be added at the same time.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)