[GitHub] [hudi] codope commented on a diff in pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation

[GitBox <gi...@apache.org>]

codope commented on code in PR #6657:
URL: https://github.com/apache/hudi/pull/6657#discussion_r978684984


##########
hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java:
##########
@@ -232,7 +240,7 @@ private class ClassSizeInfo {
     private final long fieldsSize;
     private final Field[] referenceFields;
 
-    public ClassSizeInfo(Class<?> clazz) {
+    public ClassSizeInfo(Class<?> clazz, int referenceSize, int superclassFieldPadding, int objectHeaderSize, int objectPadding) {

Review Comment:
   I wanted to make `ClassSizeInfo` static so had to pass these member variables of `ObjectSizeCalculator` as ctor args. I have reverted it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org