You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/03/11 00:37:01 UTC
Re: Review Request 43956: Created base docker image for test suite.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43956/
-----------------------------------------------------------
(Updated March 10, 2016, 3:37 p.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4684
https://issues.apache.org/jira/browse/MESOS-4684
Repository: mesos
Description
-------
Created base docker image for test suite.
Diffs (updated)
-----
src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
src/tests/containerizer/docker_archive.hpp PRE-CREATION
src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/43956/diff/
Testing
-------
(Ubuntu14.04 + clang-3.6)
make -j24 check GTEST_FILTER="*ROOT_RUNTIME_CreateDockerLocalTar*"
sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_RUNTIME_CreateDockerLocalTar*"
Thanks,
Gilbert Song
Re: Review Request 43956: Created base docker image for test suite.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43956/
-----------------------------------------------------------
(Updated March 11, 2016, 4:15 p.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4684
https://issues.apache.org/jira/browse/MESOS-4684
Repository: mesos
Description
-------
Created base docker image for test suite.
Diffs (updated)
-----
src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
src/tests/containerizer/docker_archive.hpp PRE-CREATION
src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/43956/diff/
Testing
-------
(Ubuntu14.04 + clang-3.6)
make -j24 check GTEST_FILTER="*ROOT_RUNTIME_CreateDockerLocalTar*"
sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_RUNTIME_CreateDockerLocalTar*"
Thanks,
Gilbert Song
Re: Review Request 43956: Created base docker image for test suite.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43956/#review123173
-----------------------------------------------------------
src/tests/containerizer/docker_archive.hpp (line 169)
<https://reviews.apache.org/r/43956/#comment185347>
We don't need clear anyfiles we created before once failed, right?
src/tests/containerizer/docker_archive.hpp (line 212)
<https://reviews.apache.org/r/43956/#comment185346>
Do we need pass a value to avoid it await forever? Above code also have another tarRootfs.await()
- haosdent huang
On March 10, 2016, 11:37 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43956/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 11:37 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4684
> https://issues.apache.org/jira/browse/MESOS-4684
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created base docker image for test suite.
>
>
> Diffs
> -----
>
> src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
> src/tests/containerizer/docker_archive.hpp PRE-CREATION
> src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43956/diff/
>
>
> Testing
> -------
>
> (Ubuntu14.04 + clang-3.6)
>
> make -j24 check GTEST_FILTER="*ROOT_RUNTIME_CreateDockerLocalTar*"
>
> sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_RUNTIME_CreateDockerLocalTar*"
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 43956: Created base docker image for test suite.
Posted by Gilbert Song <so...@gmail.com>.
> On March 10, 2016, 6:22 p.m., Jie Yu wrote:
> >
I think we should not use `Option<string>` here, because in a docker manifest, it does not exist None case. If any field does not exist, it should be JSON::null. Entrypoint/cmd should be either JSON::null or a JSON::array `["a", "b", ...]`.
So we should change these parameters back to `string`.
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43956/#review123068
-----------------------------------------------------------
On March 10, 2016, 3:37 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43956/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 3:37 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4684
> https://issues.apache.org/jira/browse/MESOS-4684
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created base docker image for test suite.
>
>
> Diffs
> -----
>
> src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
> src/tests/containerizer/docker_archive.hpp PRE-CREATION
> src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43956/diff/
>
>
> Testing
> -------
>
> (Ubuntu14.04 + clang-3.6)
>
> make -j24 check GTEST_FILTER="*ROOT_RUNTIME_CreateDockerLocalTar*"
>
> sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_RUNTIME_CreateDockerLocalTar*"
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 43956: Created base docker image for test suite.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43956/#review123068
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/docker_archive.hpp (lines 54 - 55)
<https://reviews.apache.org/r/43956/#comment185190>
Default should be None?
src/tests/containerizer/docker_archive.hpp (lines 153 - 154)
<https://reviews.apache.org/r/43956/#comment185191>
What if 'entrypoint' or 'cmd' is none?
- Jie Yu
On March 10, 2016, 11:37 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43956/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 11:37 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4684
> https://issues.apache.org/jira/browse/MESOS-4684
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created base docker image for test suite.
>
>
> Diffs
> -----
>
> src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
> src/tests/containerizer/docker_archive.hpp PRE-CREATION
> src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43956/diff/
>
>
> Testing
> -------
>
> (Ubuntu14.04 + clang-3.6)
>
> make -j24 check GTEST_FILTER="*ROOT_RUNTIME_CreateDockerLocalTar*"
>
> sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_RUNTIME_CreateDockerLocalTar*"
>
>
> Thanks,
>
> Gilbert Song
>
>