[GitHub] [skywalking] wankai123 commented on issue #7414: Information on Openapi based Endpoint Grouping

[GitBox <gi...@apache.org>]

wankai123 commented on issue #7414:
URL: https://github.com/apache/skywalking/issues/7414#issuecomment-893490111


   > Firstly, thanks for the quick reply!
   > 
   > > > What do you want to know?
   > > > 1 - Are there any limits on openapi yaml files? I have used EndpointGroupingRuleReader4OpenapiTest and that class does not load my openapi definition which is over 3000 lines. I figured checkstyle is limiting the definition file limits. Can i increase these values via ENV variable?
   > > 
   > > 
   > > I think we don't limit size, and checkstyle is only working for IDE, rather than runtime. Could you share more about this?
   > 
   > Its good to hear that its not applied on runtime. I have placed my openapi file under openapi-definitions folder within project and run tests from IDE, that explains why i couldnt load my file in the first place.
   > 
   > Also I couldn't run tests with openapi-defitinions folder outside project path. (ex. /tmp/openapi-definitions). ClassLoader cant reach that location. Maybe this is happening on runtime as well. Because i think i cant get i to load my yaml files. Glad to provide more detailed feedback if you direct me how to get them.
   > 
   > I will try to open a pull request for improvements whenever i can.
   
   Did you put the openapi file under `skywalking/oap-server/server-core/src/test/resources/openapi-definitions` ? If you run a test you need to put it under the test resources, not the project root resources. There are also some samples under test resources.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org