You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/16 21:57:00 UTC
[jira] [Commented] (BEAM-3063) VoidCoder should implement
structuralValue instead of forcing encoding of zero bytes
[ https://issues.apache.org/jira/browse/BEAM-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206651#comment-16206651 ]
ASF GitHub Bot commented on BEAM-3063:
--------------------------------------
GitHub user lukecwik opened a pull request:
https://github.com/apache/beam/pull/4000
[BEAM-3063] Improve VoidCoder structural value to use a single shared instance.
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lukecwik/incubator-beam beam3063
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/4000.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4000
----
commit 0d8626e5a0c99420535375a2162e22e60eeb28df
Author: Luke Cwik <lc...@google.com>
Date: 2017-10-16T20:56:04Z
[BEAM-3063] Improve VoidCoder structural value to use a single shared instance.
----
> VoidCoder should implement structuralValue instead of forcing encoding of zero bytes
> ------------------------------------------------------------------------------------
>
> Key: BEAM-3063
> URL: https://issues.apache.org/jira/browse/BEAM-3063
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Minor
>
> VoidCoder structuralValue always performs an encode on something which is effectively zero bytes instead of returning a trivial object which is always equals to itself.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)