You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by davidtzoor <gi...@git.apache.org> on 2016/06/15 08:23:17 UTC
[GitHub] zeppelin pull request #1017: Add force layout visualization in paragraphs fo...
GitHub user davidtzoor opened a pull request:
https://github.com/apache/zeppelin/pull/1017
Add force layout visualization in paragraphs for SQL queries
### What is this PR for?
Add force layout (graph) visualization to the existing set of visualizations in Zeppelin Web notp.
### What type of PR is it?
[Feature]
### What is the Jira issue?
[ZEPPELIN-1011]
### How should this be tested?
The testes are incorporated within the existing test suite.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
No.
* Is there breaking changes for older versions?
No.
* Does this needs documentation?
We can add some documentation explaining about the different fields that need to be selected in order to generate the force layout component.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davidtzoor/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1017.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1017
----
commit d9e1cf54725a1484f7912115cd3504b141ac6962
Author: David Tzoor <dt...@paypal.com>
Date: 2016-06-15T07:52:06Z
add force layout button
commit cb8fa73d7e6862494ce0be76931d38c95aa1c37a
Author: David Tzoor <dt...@paypal.com>
Date: 2016-06-15T07:53:47Z
add div and svg tags that will contain the force layout object
commit 7a05b0b919d52740aefd245c23205ea2d4ec68ab
Author: David Tzoor <dt...@paypal.com>
Date: 2016-06-15T07:56:26Z
add column drop boxes for column selection for source and destination nodes
commit 71f88fce86043bf259e30dc798afb524566be221
Author: David Tzoor <dt...@paypal.com>
Date: 2016-06-15T07:57:55Z
add force layout rendering and column selection handling methods
commit a341e8c0623c05c984ffbffed3e3163503bc205b
Author: David Tzoor <dt...@paypal.com>
Date: 2016-06-15T07:58:25Z
add CSS force layout and tooltip
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1017: Add force layout visualization in paragraphs fo...
Posted by davidtzoor <gi...@git.apache.org>.
Github user davidtzoor closed the pull request at:
https://github.com/apache/zeppelin/pull/1017
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1017: Add force layout visualization in paragraphs for SQL q...
Posted by davidtzoor <gi...@git.apache.org>.
Github user davidtzoor commented on the issue:
https://github.com/apache/zeppelin/pull/1017
closing this issue since new PR has been opened (#1024)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1017: Add force layout visualization in paragraphs for SQL q...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1017
LGTM! +1
good visualize!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1017: Add force layout visualization in paragraphs for SQL q...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1017
@davidtzoor Can you close this PR since there is a new one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1017: Add force layout visualization in paragraphs for SQL q...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1017
@davidtzoor didn't go well.
Could you try to have your changes in a different branch and re-create a PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1017: Add force layout visualization in paragraphs for SQL q...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1017
something like this might help: https://git-scm.com/book/en/v2/Git-Branching-Rebasing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1017: Add force layout visualization in paragraphs for SQL q...
Posted by davidtzoor <gi...@git.apache.org>.
Github user davidtzoor commented on the issue:
https://github.com/apache/zeppelin/pull/1017
@bzz Thanks! you mean to rebase the current `apache:master` to my forked repo (`datvidtzoor:master`), right? After I do that, what should I do?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1017: Add force layout visualization in paragraphs for SQL q...
Posted by davidtzoor <gi...@git.apache.org>.
Github user davidtzoor commented on the issue:
https://github.com/apache/zeppelin/pull/1017
@bzz I have rebased my repo with the latest master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1017: Add force layout visualization in paragraphs for SQL q...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1017
@davidtzoor great to see new visualization! Could you rebase on top of the latest master please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---