You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by hu...@apache.org on 2023/11/30 22:16:54 UTC
(airflow) branch main updated: Fix a bug with accessing hooks in EKS trigger (#35989)
This is an automated email from the ASF dual-hosted git repository.
husseinawala pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 8346fd58e8 Fix a bug with accessing hooks in EKS trigger (#35989)
8346fd58e8 is described below
commit 8346fd58e8290ba9c002a31659443601e941228e
Author: Hussein Awala <hu...@awala.fr>
AuthorDate: Fri Dec 1 00:16:47 2023 +0200
Fix a bug with accessing hooks in EKS trigger (#35989)
---
airflow/providers/amazon/aws/triggers/eks.py | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/airflow/providers/amazon/aws/triggers/eks.py b/airflow/providers/amazon/aws/triggers/eks.py
index 5a48ee39c0..eb496acff8 100644
--- a/airflow/providers/amazon/aws/triggers/eks.py
+++ b/airflow/providers/amazon/aws/triggers/eks.py
@@ -120,7 +120,7 @@ class EksDeleteClusterTrigger(AwsBaseWaiterTrigger):
return EksHook(aws_conn_id=self.aws_conn_id, region_name=self.region_name)
async def run(self):
- async with self.hook.async_conn as client:
+ async with self.hook().async_conn as client:
waiter = client.get_waiter("cluster_deleted")
if self.force_delete_compute:
await self.delete_any_nodegroups(client=client)
@@ -148,10 +148,7 @@ class EksDeleteClusterTrigger(AwsBaseWaiterTrigger):
nodegroups = await client.list_nodegroups(clusterName=self.cluster_name)
if nodegroups.get("nodegroups", None):
self.log.info("Deleting nodegroups")
- # ignoring attr-defined here because aws_base hook defines get_waiter for all hooks
- waiter = self.hook.get_waiter( # type: ignore[attr-defined]
- "all_nodegroups_deleted", deferrable=True, client=client
- )
+ waiter = self.hook().get_waiter("all_nodegroups_deleted", deferrable=True, client=client)
for group in nodegroups["nodegroups"]:
await client.delete_nodegroup(clusterName=self.cluster_name, nodegroupName=group)
await async_wait(