You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/01 21:02:39 UTC

[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #26: [FLINK-26432] Cleanly separate validator, observer and reconciler modules

gyfora commented on a change in pull request #26:
URL: https://github.com/apache/flink-kubernetes-operator/pull/26#discussion_r817137800



##########
File path: helm/flink-operator/crds/flinkdeployments.flink.apache.org-v1.yml
##########
@@ -9073,6 +9073,13 @@ spec:
                   savepointLocation:
                     type: string
                 type: object
+              jobManagerDeploymentStatus:
+                enum:

Review comment:
       @tweise you will probably need to add a special status for deployment errors. I have not added a state for that as we have no logic in place yet.
   
   Other than that we can probably reuse the reconciliation status error field for the actual error message.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org