You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by 168668660 <gi...@git.apache.org> on 2017/03/02 11:49:42 UTC
[GitHub] incubator-weex pull request #20: Feature auth support
GitHub user 168668660 opened a pull request:
https://github.com/apache/incubator-weex/pull/20
Feature auth support
module\u548ccomponent\u9274\u6743\u63a5\u53e3android\u548cios\u90fd\u5df2\u6dfb\u52a0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/168668660/incubator-weex feature-auth-support
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/20.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20
----
commit 772102018ba838ea148fbf5780b335d7d5086dd1
Author: \u7167\u70c8 <ju...@alibaba-inc.com>
Date: 2017-03-01T03:46:57Z
\u6dfb\u52a0wxmodule\u548cwxcomponent\u9274\u6743\u63a5\u53e3
commit 24e759405d9f6dec0d91ebad4da14b1b5f99c9f6
Author: \u516e\u74dc <xi...@alibaba-inc.com>
Date: 2017-03-02T09:32:35Z
\u6dfb\u52a0\u9274\u6743\u534f\u8bae \u53ca\u9274\u6743\u5361\u53e3\u63a5\u5165weex\u6e32\u67d3\u6d41\u7a0b
commit 16234eadb7c8ba0cb6676ed932683d2c73139b38
Author: \u516e\u74dc <xi...@alibaba-inc.com>
Date: 2017-03-02T10:56:04Z
\u9274\u6743\u534f\u8bae\u589e\u52a0\u53c2\u6570\u9274\u6743
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #20: Feature auth support
Posted by zshshr <gi...@git.apache.org>.
Github user zshshr commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/20#discussion_r104336145
--- Diff: android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java ---
@@ -294,6 +294,11 @@
private boolean isCommit=false;
private WXGlobalEventReceiver mGlobalEventReceiver=null;
private boolean trackComponent;
+ private boolean needValidate = false;
--- End diff --
\u6210\u5458\u53d8\u91cf\u547d\u540d\u7528\u9a86\u9a7c\u547d\u540d\uff0c\u4ee5m\u5f00\u5934
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #20: Feature auth support
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/20
@zshshr @cxfeng1 pls review this PR.
@168668660
1. It's 'Validate' not 'auth', change this PR's title.
2. Do not commit with chinese any longer, it's not meet our contribute requirement. Thanks. \U0001f604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #20: Feature auth support
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/20
@168668660 what's going on?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #20: Feature auth support
Posted by 168668660 <gi...@git.apache.org>.
Github user 168668660 closed the pull request at:
https://github.com/apache/incubator-weex/pull/20
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #20: Feature auth support
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/20
@168668660 pls fix the conflicts.
@cxfeng1 pls review the iOS part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #20: Feature auth support
Posted by zshshr <gi...@git.apache.org>.
Github user zshshr commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/20#discussion_r104336971
--- Diff: android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java ---
@@ -559,6 +564,9 @@ private void renderByUrlInternal(String pageName,
ensureRenderArchor();
pageName = wrapPageName(pageName, url);
mBundleUrl = url;
+ if(WXSDKManager.getInstance().getValidateProcessor()!=null) {
+ needValidate = WXSDKManager.getInstance().getValidateProcessor().needValidate(mBundleUrl);
+ }
--- End diff --
needValidate \u51fd\u6570\u540d\u5efa\u8bae\u6539\u6210 requestPermission\u6216 requestValidation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---