You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rajesh Battala <ra...@citrix.com> on 2013/08/10 13:36:12 UTC
Review Request 13469: CLOUDSTACK-3946 [KVM] [Zone Wide Primary Storages]
migrateVolume is deleting the volume if the source and destination pool are
same.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13469/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.
Bugs: CLOUDSTACK-3946
Repository: cloudstack-git
Description
-------
while migrating volume, if the storage and destination pool are same, we are still do overhead of copying the volume to same pool and deleting the other src copy.
fixed the issue by restricting volumemigration if the source and destination pool are same.
Diffs
-----
server/src/com/cloud/storage/VolumeManagerImpl.java 100aad3
Diff: https://reviews.apache.org/r/13469/diff/
Testing
-------
1. Successfully migrated the volume from Storagepool A to pool B.
2. migration is not allowed if the source and destination are same.
3. tried the volume with storage pool scope (ZONE and Cluster)
Thanks,
Rajesh Battala
Re: Review Request 13469: CLOUDSTACK-3946 [KVM] [Zone Wide Primary Storages]
migrateVolume is deleting the volume if the source and destination pool are
same.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13469/#review24983
-----------------------------------------------------------
Commit 4c193a1b6950932698270828a831fcd994c7ae4a in branch refs/heads/4.2 from Rajesh Battala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4c193a1 ]
CLOUDSTACK-3946 [KVM] [Zone Wide Primary Storages] migrateVolume is deleting the volume if the source and destination pool are same
- ASF Subversion and Git Services
On Aug. 12, 2013, 6:48 a.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13469/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2013, 6:48 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.
>
>
> Bugs: CLOUDSTACK-3946
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> while migrating volume, if the storage and destination pool are same, we are still do overhead of copying the volume to same pool and deleting the other src copy.
>
> fixed the issue by restricting volumemigration if the source and destination pool are same.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/VolumeManagerImpl.java 100aad3
>
> Diff: https://reviews.apache.org/r/13469/diff/
>
>
> Testing
> -------
>
> 1. Successfully migrated the volume from Storagepool A to pool B.
> 2. migration is not allowed if the source and destination are same.
> 3. tried the volume with storage pool scope (ZONE and Cluster)
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request 13469: CLOUDSTACK-3946 [KVM] [Zone Wide Primary Storages]
migrateVolume is deleting the volume if the source and destination pool are
same.
Posted by Rajesh Battala <ra...@citrix.com>.
> On Aug. 12, 2013, 8:25 a.m., Devdeep Singh wrote:
> > Ship It!
Thanks for reviewing and pushing the changes.
- Rajesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13469/#review24985
-----------------------------------------------------------
On Aug. 12, 2013, 6:48 a.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13469/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2013, 6:48 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.
>
>
> Bugs: CLOUDSTACK-3946
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> while migrating volume, if the storage and destination pool are same, we are still do overhead of copying the volume to same pool and deleting the other src copy.
>
> fixed the issue by restricting volumemigration if the source and destination pool are same.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/VolumeManagerImpl.java 100aad3
>
> Diff: https://reviews.apache.org/r/13469/diff/
>
>
> Testing
> -------
>
> 1. Successfully migrated the volume from Storagepool A to pool B.
> 2. migration is not allowed if the source and destination are same.
> 3. tried the volume with storage pool scope (ZONE and Cluster)
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request 13469: CLOUDSTACK-3946 [KVM] [Zone Wide Primary Storages]
migrateVolume is deleting the volume if the source and destination pool are
same.
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13469/#review24985
-----------------------------------------------------------
Ship it!
Ship It!
- Devdeep Singh
On Aug. 12, 2013, 6:48 a.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13469/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2013, 6:48 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.
>
>
> Bugs: CLOUDSTACK-3946
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> while migrating volume, if the storage and destination pool are same, we are still do overhead of copying the volume to same pool and deleting the other src copy.
>
> fixed the issue by restricting volumemigration if the source and destination pool are same.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/VolumeManagerImpl.java 100aad3
>
> Diff: https://reviews.apache.org/r/13469/diff/
>
>
> Testing
> -------
>
> 1. Successfully migrated the volume from Storagepool A to pool B.
> 2. migration is not allowed if the source and destination are same.
> 3. tried the volume with storage pool scope (ZONE and Cluster)
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request 13469: CLOUDSTACK-3946 [KVM] [Zone Wide Primary Storages]
migrateVolume is deleting the volume if the source and destination pool are
same.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13469/#review24984
-----------------------------------------------------------
Commit be9dbcc2c5edb995c48558ea5e1a87c8d3012965 in branch refs/heads/master from Rajesh Battala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=be9dbcc ]
CLOUDSTACK-3946 [KVM] [Zone Wide Primary Storages] migrateVolume is deleting the volume if the source and destination pool are same
- ASF Subversion and Git Services
On Aug. 12, 2013, 6:48 a.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13469/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2013, 6:48 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.
>
>
> Bugs: CLOUDSTACK-3946
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> while migrating volume, if the storage and destination pool are same, we are still do overhead of copying the volume to same pool and deleting the other src copy.
>
> fixed the issue by restricting volumemigration if the source and destination pool are same.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/VolumeManagerImpl.java 100aad3
>
> Diff: https://reviews.apache.org/r/13469/diff/
>
>
> Testing
> -------
>
> 1. Successfully migrated the volume from Storagepool A to pool B.
> 2. migration is not allowed if the source and destination are same.
> 3. tried the volume with storage pool scope (ZONE and Cluster)
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request 13469: CLOUDSTACK-3946 [KVM] [Zone Wide Primary Storages]
migrateVolume is deleting the volume if the source and destination pool are
same.
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13469/
-----------------------------------------------------------
(Updated Aug. 12, 2013, 6:48 a.m.)
Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.
Changes
-------
rebased with 4.2
Bugs: CLOUDSTACK-3946
Repository: cloudstack-git
Description
-------
while migrating volume, if the storage and destination pool are same, we are still do overhead of copying the volume to same pool and deleting the other src copy.
fixed the issue by restricting volumemigration if the source and destination pool are same.
Diffs (updated)
-----
server/src/com/cloud/storage/VolumeManagerImpl.java 100aad3
Diff: https://reviews.apache.org/r/13469/diff/
Testing
-------
1. Successfully migrated the volume from Storagepool A to pool B.
2. migration is not allowed if the source and destination are same.
3. tried the volume with storage pool scope (ZONE and Cluster)
Thanks,
Rajesh Battala