You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by JoshRosen <gi...@git.apache.org> on 2015/12/30 20:22:16 UTC

[GitHub] spark pull request: [SPARK-10359][DONOTMERGE] Enumerate dependenci...

Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/10461#issuecomment-168059387
  
    Spotted the problem: the original logic for checking `should_run_build_tests` was wrong: it needs to loop over all `test_modules` (using `any`) and the `root` module needs to have the build tests enabled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org