You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mgaido91 (via GitHub)" <gi...@apache.org> on 2026/03/12 23:11:15 UTC

Re: [PR] [SPARK-55975][SQL][TESTS] NaN comparison can cause false UT failures due to different NaNs [spark]

mgaido91 commented on code in PR #54772:
URL: https://github.com/apache/spark/pull/54772#discussion_r2927935132


##########
sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala:
##########
@@ -117,6 +117,15 @@ class MathFunctionsSuite extends QueryTest with SharedSparkSession {
     )
   }
 
+  test("different NaN comparison") {
+    QueryTest.compare(
+      java.lang.Double.longBitsToDouble(0x7ff8000000000000L),
+      java.lang.Double.longBitsToDouble(0xfff8000000000000L))

Review Comment:
   sure, sorry, I forgot pushing a commit :) thanks, good to see you as well @dongjoon-hyun :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org