You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/06/11 19:39:39 UTC
Re: Review Request 22424: Changed RateLimiter to work directly with 'double
permitsPerSecond'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22424/
-----------------------------------------------------------
(Updated June 11, 2014, 10:39 a.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, and Vinod Kone.
Changes
-------
More changes to RateLimiter. See Summary.
Summary (updated)
-----------------
Changed RateLimiter to work directly with 'double permitsPerSecond'.
Bugs: MESOS-1444
https://issues.apache.org/jira/browse/MESOS-1444
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/limiter.hpp bbe82266b82bf226f4a9048640a41c424f8d13b0
Diff: https://reviews.apache.org/r/22424/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 22424: Changed RateLimiter to work directly with 'double
permitsPerSecond'.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22424/#review45817
-----------------------------------------------------------
Patch looks great!
Reviews applied: [22424]
All tests passed.
- Mesos ReviewBot
On June 13, 2014, 10:34 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22424/
> -----------------------------------------------------------
>
> (Updated June 13, 2014, 10:34 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1444
> https://issues.apache.org/jira/browse/MESOS-1444
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/limiter.hpp bbe82266b82bf226f4a9048640a41c424f8d13b0
>
> Diff: https://reviews.apache.org/r/22424/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 22424: Changed RateLimiter to work directly with 'double
permitsPerSecond'.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22424/
-----------------------------------------------------------
(Updated June 13, 2014, 3:34 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
Added 'explicit'. NNFR.
Bugs: MESOS-1444
https://issues.apache.org/jira/browse/MESOS-1444
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/limiter.hpp bbe82266b82bf226f4a9048640a41c424f8d13b0
Diff: https://reviews.apache.org/r/22424/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 22424: Changed RateLimiter to work directly with 'double
permitsPerSecond'.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22424/#review45430
-----------------------------------------------------------
3rdparty/libprocess/include/process/limiter.hpp
<https://reviews.apache.org/r/22424/#comment80290>
explicit please
3rdparty/libprocess/include/process/limiter.hpp
<https://reviews.apache.org/r/22424/#comment80291>
explicit please
- Dominic Hamon
On June 11, 2014, 10:39 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22424/
> -----------------------------------------------------------
>
> (Updated June 11, 2014, 10:39 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, and Vinod Kone.
>
>
> Bugs: MESOS-1444
> https://issues.apache.org/jira/browse/MESOS-1444
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/limiter.hpp bbe82266b82bf226f4a9048640a41c424f8d13b0
>
> Diff: https://reviews.apache.org/r/22424/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 22424: Changed RateLimiter to work directly with 'double
permitsPerSecond'.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22424/#review45402
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 11, 2014, 5:39 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22424/
> -----------------------------------------------------------
>
> (Updated June 11, 2014, 5:39 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, and Vinod Kone.
>
>
> Bugs: MESOS-1444
> https://issues.apache.org/jira/browse/MESOS-1444
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/limiter.hpp bbe82266b82bf226f4a9048640a41c424f8d13b0
>
> Diff: https://reviews.apache.org/r/22424/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>