You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Igor Vaynberg (JIRA)" <ji...@apache.org> on 2007/09/12 07:35:32 UTC

[jira] Commented: (WICKET-946) WebRequestCodingStrategy is not synchronized

    [ https://issues.apache.org/jira/browse/WICKET-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526671 ] 

Igor Vaynberg commented on WICKET-946:
--------------------------------------

what exactly is the usecase for this? you are only meant to mount/unmount pages in your application.init() method

> WebRequestCodingStrategy is not synchronized
> --------------------------------------------
>
>                 Key: WICKET-946
>                 URL: https://issues.apache.org/jira/browse/WICKET-946
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: John Ray
>            Assignee: Igor Vaynberg
>         Attachments: WebRequestCodingStrategy-patch, WebRequestCodingStrategy.java
>
>
> The WebRequestCodingStrategy class uses a TreeMap to store mounted pages however there is no synchronization done. This will cause problems if pages are being mounted/unmounted by one thread while web requests are being served from a different one. It could also cause problems if two threads try to mount/unmount pages at the same time.
> I'll include a patch to fix this as well as a new version of the java file that you can use if you want
> Keep up the good work

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.