[jira] [Commented] (IGNITE-4111) Communication fails to send message if target node did not finish join process

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-4111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15711949#comment-15711949 ] 

ASF GitHub Bot commented on IGNITE-4111:
----------------------------------------

GitHub user akuramshingg opened a pull request:

    https://github.com/apache/ignite/pull/1307

    IGNITE-4111

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-4111

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/1307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1307
    
----

----


> Communication fails to send message if target node did not finish join process
> ------------------------------------------------------------------------------
>
>                 Key: IGNITE-4111
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4111
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>            Reporter: Semen Boikov
>            Assignee: Semen Boikov
>             Fix For: 2.0
>
>         Attachments: test onFirstMessage hang.log
>
>
> Currently this scenario is possible:
> - joining node sent join request and waits for TcpDiscoveryNodeAddFinishedMessage inside ServerImpl.joinTopology
> - others nodes already see this node and can send messages to it (for example try to run compute job on this node)
> - joining node can not receive message: TcpCommunicationSpi will hang inside 'onFirstMessage' on 'getSpiContext' call, so sending node will get error trying to establish connection
> Possible fix: if in onFirstMessage() spi context is not available, then TcpCommunicationSpi  should send special response which indicates that this node is not ready yet, and sender should retry after some time.
> Also need check internal code for places where message can be unnecessarily sent to node: one such place is GridCachePartitionExchangeManager.refreshPartitions - message is sent to all known nodes, but here we can filter by node order / finished exchage version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)