You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Sander Striker <st...@apache.org> on 2003/02/12 10:50:59 UTC
Bindings broken?
I just updated to HEAD and noticed, when I ran mailer.py, that the bindings are broken:
Traceback (most recent call last):
File "/opt/svn-install/hooks/mailer.py", line 773, in ?
svn.util.run_app(main, config_fname, repos_dir, revision)
File "/opt/svn-install/svn-4854MS/lib/python2.2/site-packages/svn/util.py", line 38, in run_app
return apply(func, (pool,) + args, kw)
File "/opt/svn-install/hooks/mailer.py", line 61, in main
output.generate(groups, pool)
File "/opt/svn-install/hooks/mailer.py", line 142, in generate
generate_content(self, self.cfg, self.repos, self.changelist, pool)
File "/opt/svn-install/hooks/mailer.py", line 299, in generate_content
date = time.ctime(svn.util.secs_from_timestr(svndate, pool))
File "/opt/svn-install/svn-4854MS/lib/python2.2/site-packages/svn/util.py", line 71, in secs_from_timestr
aprtime = svn_time_from_cstring(svn_datetime, pool)
TypeError: svn_time_from_cstring() takes exactly 3 arguments (2 given)
Last working install for me was 4720.
Sander
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Bindings broken?
Posted by Daniel Rall <dl...@finemaltcoding.com>.
David Summers <da...@summersoft.fay.ar.us> writes:
...
> Would a good test of them be to use cvs2svn to convert a test repository?
>
> Surely that would test both cvs2svn and the SWIG/Pythong bindings....
I like it.
--
Daniel Rall <dl...@finemaltcoding.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Bindings broken?
Posted by Marshall White <cs...@yahoo.com>.
David,
Certainly using cvs2svn would test SOME aspects of the SWIG/Python binding.
This message
http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=30456
contains a simple script that I wrote that tests some of the things that I (know are/knew were)
broken.
In fact I put in this thread
http://subversion.tigris.org/servlets/BrowseList?list=dev&by=thread&from=80528
a patch I *think* would fix the problem. Of course it is really old now.
I never searched the bugzilla thing to see if this was a known problem, and I either got "pocket
vetoed" or "over looked." So I went to work on "other things" like trying to find a job.
ANYWAY, the script in the email shows just how simple a Python script can be and still use SVN. I
was quite impressed how easy it was. Maybe you can take some inspiration from it. (And I won't
feel like I wrote it for nothing...) :-)
Marshall White
--- David Summers <da...@summersoft.fay.ar.us> wrote:
>
> On 12 Feb 2003, Daniel Rall wrote:
> > Does make check test the SWIG/Python bindings?
>
> I don't believe it does, because a couple of times things that depend on
> the bindings have been broken by the SWIG/Pythong bindings being broken.
>
> Would be nice if we could have some simple regression tests.
>
> If I knew anything about them maybe I could work on that...guess it is
> time to start learning.
>
> Would a good test of them be to use cvs2svn to convert a test repository?
>
> Surely that would test both cvs2svn and the SWIG/Pythong bindings....
>
> --
> David Wayne Summers "Linux: Because reboots are for hardware upgrades!"
> david@summersoft.fay.ar.us PGP Key: http://summersoft.fay.ar.us/~david/pgp.txt
> PGP Key fingerprint = C0 E0 4F 50 DD A9 B6 2B 60 A1 31 7E D2 28 6D A8
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Bindings broken?
Posted by David Summers <da...@summersoft.fay.ar.us>.
On 12 Feb 2003, Daniel Rall wrote:
> Does make check test the SWIG/Python bindings?
I don't believe it does, because a couple of times things that depend on
the bindings have been broken by the SWIG/Pythong bindings being broken.
Would be nice if we could have some simple regression tests.
If I knew anything about them maybe I could work on that...guess it is
time to start learning.
Would a good test of them be to use cvs2svn to convert a test repository?
Surely that would test both cvs2svn and the SWIG/Pythong bindings....
--
David Wayne Summers "Linux: Because reboots are for hardware upgrades!"
david@summersoft.fay.ar.us PGP Key: http://summersoft.fay.ar.us/~david/pgp.txt
PGP Key fingerprint = C0 E0 4F 50 DD A9 B6 2B 60 A1 31 7E D2 28 6D A8
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Bindings broken?
Posted by Daniel Rall <dl...@finemaltcoding.com>.
Does make check test the SWIG/Python bindings?
--
Daniel Rall <dl...@finemaltcoding.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
RE: Bindings broken?
Posted by Sander Striker <st...@apache.org>.
> From: Edward S. Marshall [mailto:esm@logic.net]
> Sent: Wednesday, February 12, 2003 5:16 PM
> On Wed, Feb 12, 2003 at 09:59:58AM -0600, Edward S. Marshall wrote:
>> Reverting this ought to bring back the old behavior, to the best of my
>> knowledge (since this definitely isn't java-specific behavior).
>
> Yep, that fixed it. Patch attached below. Someone from the Java camp
> should probably test this. ;-)
I'm not from the Java camp, but it looks sane to me ;). Committed, thanks.
Sander
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Bindings broken?
Posted by "Edward S. Marshall" <es...@logic.net>.
On Wed, Feb 12, 2003 at 09:59:58AM -0600, Edward S. Marshall wrote:
> Reverting this ought to bring back the old behavior, to the best of my
> knowledge (since this definitely isn't java-specific behavior).
Yep, that fixed it. Patch attached below. Someone from the Java camp
should probably test this. ;-)
* subversion/bindings/swig/apr.i: Revert change from r4788 which made
OUTPUT parameter conversion for apr_time_t a Java-specific change.
Pythons need lovin' too...
Index: subversion/bindings/swig/apr.i
===================================================================
--- subversion/bindings/swig/apr.i (revision 4856)
+++ subversion/bindings/swig/apr.i (working copy)
@@ -71,7 +71,7 @@
%apply long long { apr_time_t };
/* 'apr_time_t *' will always be an OUTPUT parameter */
-%typemap(java,in,numinputs=0) apr_time_t * (apr_time_t temp)
+%typemap(in,numinputs=0) apr_time_t * (apr_time_t temp)
"$1 = &temp;";
%typemap(python,argout,fragment="t_output_helper") apr_time_t *
--
Edward S. Marshall <es...@logic.net>
http://esm.logic.net/
Felix qui potuit rerum cognoscere causas.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Bindings broken?
Posted by "Edward S. Marshall" <es...@logic.net>.
On Wed, Feb 12, 2003 at 11:50:59AM +0100, Sander Striker wrote:
> TypeError: svn_time_from_cstring() takes exactly 3 arguments (2 given)
Conversion of apr_time_t to an OUTPUT parameter isn't taking place any
more, because of this change to subversion/bindings/swig/apr.i in r4788:
---snip---
/* 'apr_time_t *' will always be an OUTPUT parameter */
-%typemap(in,numinputs=0) apr_time_t * (apr_time_t temp)
+%typemap(java,in,numinputs=0) apr_time_t * (apr_time_t temp)
"$1 = &temp;";
---snip---
Reverting this ought to bring back the old behavior, to the best of my
knowledge (since this definitely isn't java-specific behavior).
--
Edward S. Marshall <es...@logic.net>
http://esm.logic.net/
Felix qui potuit rerum cognoscere causas.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org