[GitHub] [druid] gianm commented on issue #9503: Link up row-based datasources to serving layer.

[GitBox <gi...@apache.org>]

gianm commented on issue #9503: Link up row-based datasources to serving layer.
URL: https://github.com/apache/druid/pull/9503#issuecomment-597721115
 
 
   > It might be nice to have some additional test coverage with other query engines to make sure there isn't any funny stuff, but since this functionality isn't really documented yet I'm ok if this is filled out in one or more future PRs.
   
   There should be a _lot_ more in a future patch that connects this to the SQL layer. But for now, in this patch, there are integration tests.
   
   > Also, there seems to be a legitimate test failure, you forgot to update `InlineDataSourceTest.test_isConcrete` to reflect the newly concrete status of `InlineDataSource`.
   
   Thanks, I'll fix that. I also got one of the integration tests wrong, which I'll fix:
   
   ```
    expectedResults: [{"version":"v1","timestamp":"0000-01-01T00:00:00.000Z","event":{"k":"Wikipedia:Vandalismusmeldung","v":"lookup!","nonexistent":null,"rows":1}}] 
   
    actualResults : [{"version":"v1","timestamp":"0000-01-01T00:00:00.000Z","event":{"v":"inline join!","k":"Wikipedia:Vandalismusmeldung","rows":1,"nonexistent":null}}]
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org