You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/10 01:50:53 UTC

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8172: Allow users to estimate query cost before executing it

betodealmeida commented on a change in pull request #8172: Allow users to estimate query cost before executing it
URL: https://github.com/apache/incubator-superset/pull/8172#discussion_r322522527
 
 

 ##########
 File path: superset/assets/src/SqlLab/components/EstimateQueryCostButton.jsx
 ##########
 @@ -0,0 +1,108 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import PropTypes from 'prop-types';
+import { Table } from 'reactable-arc';
+import { Alert } from 'react-bootstrap';
+import { t } from '@superset-ui/translation';
+
+import Button from '../../components/Button';
+import Loading from '../../components/Loading';
+import ModalTrigger from '../../components/ModalTrigger';
+
+const propTypes = {
+  dbId: PropTypes.number.isRequired,
+  schema: PropTypes.string.isRequired,
+  sql: PropTypes.string.isRequired,
+  getEstimate: PropTypes.func.isRequired,
+  queryCostEstimate: PropTypes.Object,
+  selectedText: PropTypes.string,
+  tooltip: PropTypes.string,
+  disabled: PropTypes.bool,
+};
+const defaultProps = {
+  queryCostEstimate: [],
+  tooltip: '',
+  disabled: false,
+};
+
+class EstimateQueryCostButton extends React.PureComponent {
+  constructor(props) {
+    super(props);
+    this.queryCostModal = React.createRef();
+    this.onClick = this.onClick.bind(this);
+    this.renderModalBody = this.renderModalBody.bind(this);
+  }
+
+  onClick() {
+    this.props.getEstimate();
+  }
+
+  renderModalBody() {
+    if (this.props.queryCostEstimate.error !== null) {
+      return (
+        <Alert key="query-estimate-error" bsStyle="danger">
+          {this.props.queryCostEstimate.error}
+        </Alert>
+      );
+    } else if (this.props.queryCostEstimate.completed) {
+      return (
+        <Table
+          className="table cost-estimate"
+          data={this.props.queryCostEstimate.cost}
+        />
+      );
+    }
+    return <Loading position="normal" />;
+  }
+
+  render() {
+    const { disabled, selectedText, tooltip } = this.props;
+    const btnText = selectedText
+      ? t('Estimate Selected Query Cost')
+      : t('Estimate Query Cost');
+    return (
+      <span className="EstimateQueryCostButton">
+        <ModalTrigger
+          ref={this.queryCostModal}
+          modalTitle={t('Query Cost Estimate')}
+          modalBody={this.renderModalBody()}
+          triggerNode={
+            <Button
+              bsStyle="warning"
+              bsSize="small"
+              onClick={this.onClick}
 
 Review comment:
   It does, it shows a loading wheel.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org