You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/04/09 08:45:25 UTC
[jira] [Commented] (SHINDIG-1698) Need to support query parameter
for Social REST API
[ https://issues.apache.org/jira/browse/SHINDIG-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249703#comment-13249703 ]
jiraposter@reviews.apache.org commented on SHINDIG-1698:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4680/
-----------------------------------------------------------
Review request for shindig, Ryan Baxter, Eric Woods, and Stanton Sievers.
Summary
-------
This is the patch for https://reviews.apache.org/r/3764 as xuli is not working on it.
@Ryan, I have merged line 58 and 59 of /trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptions.java and break line 60 into multiple lines. As predefinedParameters is using RequestItem, it can not be changed to private static final.
This addresses bug SHINDIG-1698.
https://issues.apache.org/jira/browse/SHINDIG-1698
Diffs
-----
Diff: https://reviews.apache.org/r/4680/diff
Testing
-------
done
Thanks,
Yao
> Need to support query parameter for Social REST API
> ---------------------------------------------------
>
> Key: SHINDIG-1698
> URL: https://issues.apache.org/jira/browse/SHINDIG-1698
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0-beta1
> Reporter: li xu
> Fix For: 2.5.0
>
> Attachments: parameter_patch.txt
>
>
> We have a use case that need to support optional parameters on Social REST API.
> Per open social spec discussion, provider specific parameter can be supported. Please see the link below for details.
> https://groups.google.com/forum/#!topic/opensocial-and-gadgets-spec/rOBmu4QGtwg
> This patch implemented optional parameter as a field in CollectionOptions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira