You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2024/03/14 01:40:42 UTC

(superset) branch master updated: fix: docker builds in master fail (#27503)

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 2fdf6d7b64 fix: docker builds in master fail (#27503)
2fdf6d7b64 is described below

commit 2fdf6d7b6484c4110d06e90605dae405a6df38f8
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Wed Mar 13 18:40:35 2024 -0700

    fix: docker builds in master fail (#27503)
---
 .github/supersetbot/src/docker.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.github/supersetbot/src/docker.js b/.github/supersetbot/src/docker.js
index c287e6ae18..1bf9695c23 100644
--- a/.github/supersetbot/src/docker.js
+++ b/.github/supersetbot/src/docker.js
@@ -79,7 +79,7 @@ export function getDockerTags({
 }
 
 export function getDockerCommand({
-  preset, platform, isAuthenticated, buildContext, buildContextRef, forceLatest = false,
+  preset, platform, buildContext, buildContextRef, forceLatest = false,
 }) {
   const platforms = platform;
 
@@ -113,6 +113,8 @@ export function getDockerCommand({
   const tags = getDockerTags({
     preset, platforms, sha, buildContext, buildContextRef: ref, forceLatest,
   }).map((tag) => `-t ${tag}`).join(' \\\n        ');
+  const isAuthenticated = !!(process.env.DOCKERHUB_TOKEN && process.env.DOCKERHUB_USER);
+
   const dockerArgs = isAuthenticated ? '--push' : '--load';
   const targetArgument = buildTarget ? `--target ${buildTarget}` : '';
   const cacheRef = `${CACHE_REPO}:${pyVer}`;