You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/17 20:22:14 UTC

[GitHub] [beam] jaketf commented on a change in pull request #11450: [BEAM-9468] Hl7v2 io patches

jaketf commented on a change in pull request #11450: [BEAM-9468] Hl7v2 io patches
URL: https://github.com/apache/beam/pull/11450#discussion_r410451265
 
 

 ##########
 File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IOWriteIT.java
 ##########
 @@ -46,6 +45,8 @@
   private static final String HL7V2_STORE_NAME =
       "hl7v2_store_write_it_" + System.currentTimeMillis() + "_" + (new SecureRandom().nextInt(32));
 
+  @Rule public transient TestPipeline pipeline = TestPipeline.create();
 
 Review comment:
   I could add 
   ```java
   pipeline.getOptions().as(DirectOptions.class).setBlockOnRun(true);
   ```
   But I think this is the same as `pipeline.run().waitUntilFinish();` for batch pipelines which I already use.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services