You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/09 12:03:14 UTC
[GitHub] [incubator-superset] ali-bahjati opened a new pull request #8940:
Add Iran to Country Visualization
ali-bahjati opened a new pull request #8940: Add Iran to Country Visualization
URL: https://github.com/apache/incubator-superset/pull/8940
- [x] Enhancement (new features, refinement)
This PR Requires [This superset-ui-plugins PR](https://github.com/apache-superset/superset-ui-plugins/pull/306) to be merged first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on issue #8940: Add
Iran to Country Visualization
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on issue #8940: Add Iran to Country Visualization
URL: https://github.com/apache/incubator-superset/pull/8940#issuecomment-573204754
It looks like many countries are missing from this list. Would you mind adding all of the missing countries?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ali-bahjati commented on issue #8940: Add Iran
to Country Visualization
Posted by GitBox <gi...@apache.org>.
ali-bahjati commented on issue #8940: Add Iran to Country Visualization
URL: https://github.com/apache/incubator-superset/pull/8940#issuecomment-600540532
@villebro Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8940: Add Iran to
Country Visualization
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #8940: Add Iran to Country Visualization
URL: https://github.com/apache/incubator-superset/pull/8940#issuecomment-600585295
Thanks @ali-bahjati !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #8940: Add Iran
to Country Visualization
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #8940: Add Iran to Country Visualization
URL: https://github.com/apache/incubator-superset/pull/8940
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ali-bahjati commented on issue #8940: Add Iran
to Country Visualization
Posted by GitBox <gi...@apache.org>.
ali-bahjati commented on issue #8940: Add Iran to Country Visualization
URL: https://github.com/apache/incubator-superset/pull/8940#issuecomment-600513828
Any comments on this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ali-bahjati commented on issue #8940: Add Iran
to Country Visualization
Posted by GitBox <gi...@apache.org>.
ali-bahjati commented on issue #8940: Add Iran to Country Visualization
URL: https://github.com/apache/incubator-superset/pull/8940#issuecomment-583644110
My PR in superset-ui is merged now. I think you can merge this. I don't know should I increase superset-ui-plugins package version or no.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ali-bahjati commented on issue #8940: Add Iran
to Country Visualization
Posted by GitBox <gi...@apache.org>.
ali-bahjati commented on issue #8940: Add Iran to Country Visualization
URL: https://github.com/apache/incubator-superset/pull/8940#issuecomment-593235226
@mistercrunch Is it ok to merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #8940: Add Iran to
Country Visualization
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #8940: Add Iran to Country Visualization
URL: https://github.com/apache/incubator-superset/pull/8940#issuecomment-573784377
@robdiciuccio looks like this has a corresponding pr https://github.com/apache-superset/superset-ui-plugins/pull/306 that includes the geojson file for this country. Adding _all_ the missing countries may be a significant amount of work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8940:
Add Iran to Country Visualization
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8940: Add Iran to Country Visualization
URL: https://github.com/apache/incubator-superset/pull/8940#issuecomment-572535148
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8940?src=pr&el=h1) Report
> Merging [#8940](https://codecov.io/gh/apache/incubator-superset/pull/8940?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c36a7e3adae0ef27c3f16f890a396e2463c63bdd&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8940 +/- ##
=======================================
Coverage 59.08% 59.08%
=======================================
Files 374 374
Lines 12205 12205
Branches 2989 2989
=======================================
Hits 7211 7211
Misses 4815 4815
Partials 179 179
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8940?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8940/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `40.14% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8940?src=pr&el=footer). Last update [c36a7e3...c76993a](https://codecov.io/gh/apache/incubator-superset/pull/8940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8940: Add Iran
to Country Visualization
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8940: Add Iran to Country Visualization
URL: https://github.com/apache/incubator-superset/pull/8940#issuecomment-572535148
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8940?src=pr&el=h1) Report
> Merging [#8940](https://codecov.io/gh/apache/incubator-superset/pull/8940?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2d456e88ebf1ef6fe4da7bdca1e25dcf098f6533?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8940 +/- ##
=======================================
Coverage 58.97% 58.97%
=======================================
Files 359 359
Lines 11333 11333
Branches 2787 2787
=======================================
Hits 6684 6684
Misses 4471 4471
Partials 178 178
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8940?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8940/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `40.14% <ø> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8940?src=pr&el=footer). Last update [2d456e8...dd1fbaf](https://codecov.io/gh/apache/incubator-superset/pull/8940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8940: Add Iran to
Country Visualization
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #8940: Add Iran to Country Visualization
URL: https://github.com/apache/incubator-superset/pull/8940#issuecomment-600519560
@ali-bahjati can you rebase? There's a conflict on `controls.jsx` that's blocking merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org