You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "AMashenkov (via GitHub)" <gi...@apache.org> on 2023/08/23 11:32:30 UTC

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2485: IGNITE-20265 Check and slightly refactor the validation of tables and indexes in the catalog

AMashenkov commented on code in PR #2485:
URL: https://github.com/apache/ignite-3/pull/2485#discussion_r1302881562


##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java:
##########
@@ -965,7 +936,25 @@ public void listen(CatalogEvent evt, EventListener<? extends CatalogEventParamet
         listen(evt, (EventListener<CatalogEventParameters>) closure);
     }
 
-    private static @Nullable CatalogDataStorageDescriptor dataStorage(@Nullable DataStorageParams params) {
-        return params == null ? null : fromParams(params);
+    private static void checkNotExistsIndexOrTable(CatalogSchemaDescriptor schema, String indexName) {

Review Comment:
   `ensureNameIsUnique` or `ensureNoTableOrIndexExistsWithSameName` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org