You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Joep Rottinghuis (JIRA)" <ji...@apache.org> on 2011/09/20 06:22:09 UTC
[jira] [Created] (HBASE-4447) Allow hbase.version to be passed in
as command-line argument
Allow hbase.version to be passed in as command-line argument
------------------------------------------------------------
Key: HBASE-4447
URL: https://issues.apache.org/jira/browse/HBASE-4447
Project: HBase
Issue Type: Improvement
Components: build
Affects Versions: 0.92.0
Reporter: Joep Rottinghuis
Currently the build always produces the jars and tarball according to the version baked into the POM.
When we modify this to allow the version to be passed in as a command-line argument, it can still default to the same behavior, yet give the flexibility for an internal build to tag on own version.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4447) Allow hbase.version to be passed in
as command-line argument
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-4447.
--------------------------
Resolution: Fixed
Fix Version/s: 0.92.0
Hadoop Flags: [Reviewed]
Applied to trunk and 0.92 branch. Thanks for patch Joep.
> Allow hbase.version to be passed in as command-line argument
> ------------------------------------------------------------
>
> Key: HBASE-4447
> URL: https://issues.apache.org/jira/browse/HBASE-4447
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.92.0
> Reporter: Joep Rottinghuis
> Fix For: 0.92.0
>
> Attachments: HBASE-4447-0.92.patch
>
>
> Currently the build always produces the jars and tarball according to the version baked into the POM.
> When we modify this to allow the version to be passed in as a command-line argument, it can still default to the same behavior, yet give the flexibility for an internal build to tag on own version.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4447) Allow hbase.version to be passed in
as command-line argument
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133765#comment-13133765 ]
stack commented on HBASE-4447:
------------------------------
@Joep I'm going to revert this change (See Eric's input above). I also see that when you build with mvn 3 it complains:
{code}
pynchon-645:clean-trunk stack$ ~/bin/apache-maven-3.0.3/bin/mvn apache-rat:rat
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.apache.hbase:hbase:jar:0.93-SNAPSHOT
[WARNING] 'version' contains an expression but should be a constant. @ org.apache.hbase:hbase:${hbase.version}, /Users/stack/checkout/clean-trunk/pom.xml, line 40, column 12
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
{code}
You ok with using the versions plugin as per Eric above?
> Allow hbase.version to be passed in as command-line argument
> ------------------------------------------------------------
>
> Key: HBASE-4447
> URL: https://issues.apache.org/jira/browse/HBASE-4447
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.92.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Fix For: 0.92.0
>
> Attachments: HBASE-4447-0.92.patch
>
>
> Currently the build always produces the jars and tarball according to the version baked into the POM.
> When we modify this to allow the version to be passed in as a command-line argument, it can still default to the same behavior, yet give the flexibility for an internal build to tag on own version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4447) Allow hbase.version to be passed in
as command-line argument
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HBASE-4447:
----------------------------
Assignee: Joep Rottinghuis
> Allow hbase.version to be passed in as command-line argument
> ------------------------------------------------------------
>
> Key: HBASE-4447
> URL: https://issues.apache.org/jira/browse/HBASE-4447
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.92.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Fix For: 0.92.0
>
> Attachments: HBASE-4447-0.92.patch
>
>
> Currently the build always produces the jars and tarball according to the version baked into the POM.
> When we modify this to allow the version to be passed in as a command-line argument, it can still default to the same behavior, yet give the flexibility for an internal build to tag on own version.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4447) Allow hbase.version to be passed in
as command-line argument
Posted by "Jonathan Gray (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133780#comment-13133780 ]
Jonathan Gray commented on HBASE-4447:
--------------------------------------
Shouldn't be fixed? Should be Invalid or some other?
Thanks for all the cleanup stack!
> Allow hbase.version to be passed in as command-line argument
> ------------------------------------------------------------
>
> Key: HBASE-4447
> URL: https://issues.apache.org/jira/browse/HBASE-4447
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.92.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Fix For: 0.92.0
>
> Attachments: HBASE-4447-0.92.patch
>
>
> Currently the build always produces the jars and tarball according to the version baked into the POM.
> When we modify this to allow the version to be passed in as a command-line argument, it can still default to the same behavior, yet give the flexibility for an internal build to tag on own version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4447) Allow hbase.version to be passed in
as command-line argument
Posted by "Joep Rottinghuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108363#comment-13108363 ]
Joep Rottinghuis commented on HBASE-4447:
-----------------------------------------
Before patch:
mvn clean install -DskipTests=true -Dhadoop.profile=22 -Dhadoop.version=0.22-argon-SNAPSHOT > build.log
look in workspace/target directory: hbase-0.92.0-SNAPSHOT.tar.gz and hbase-0.92.0-SNAPSHOT.jar are produced.
After patch:
mvn install -DskipTests=true -Dhadoop.profile=22 -Dhadoop.version=0.22-argon-SNAPSHOT -Dhbase.version=0.92-joep-0 > build.log
look in workspace/target directory: hbase-0.92-joep-0.tar.gz and hbase-0.92-joep-0.jar are produced.
> Allow hbase.version to be passed in as command-line argument
> ------------------------------------------------------------
>
> Key: HBASE-4447
> URL: https://issues.apache.org/jira/browse/HBASE-4447
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.92.0
> Reporter: Joep Rottinghuis
> Attachments: HBASE-4447-0.92.patch
>
>
> Currently the build always produces the jars and tarball according to the version baked into the POM.
> When we modify this to allow the version to be passed in as a command-line argument, it can still default to the same behavior, yet give the flexibility for an internal build to tag on own version.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4447) Allow hbase.version to be passed in
as command-line argument
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108495#comment-13108495 ]
Hudson commented on HBASE-4447:
-------------------------------
Integrated in HBase-0.92 #5 (See [https://builds.apache.org/job/HBase-0.92/5/])
HBASE-4447 Allow hbase.version to be passed in as command-line argument
stack :
Files :
* /hbase/branches/0.92/pom.xml
> Allow hbase.version to be passed in as command-line argument
> ------------------------------------------------------------
>
> Key: HBASE-4447
> URL: https://issues.apache.org/jira/browse/HBASE-4447
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.92.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Fix For: 0.92.0
>
> Attachments: HBASE-4447-0.92.patch
>
>
> Currently the build always produces the jars and tarball according to the version baked into the POM.
> When we modify this to allow the version to be passed in as a command-line argument, it can still default to the same behavior, yet give the flexibility for an internal build to tag on own version.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4447) Allow hbase.version to be passed in
as command-line argument
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135127#comment-13135127 ]
Hudson commented on HBASE-4447:
-------------------------------
Integrated in HBase-0.92 #79 (See [https://builds.apache.org/job/HBase-0.92/79/])
HBASE-4447 Allow hbase.version to be passed in as command-line argument; REVERTsvn diffsvn diff
stack :
Files :
* /hbase/branches/0.92/pom.xml
> Allow hbase.version to be passed in as command-line argument
> ------------------------------------------------------------
>
> Key: HBASE-4447
> URL: https://issues.apache.org/jira/browse/HBASE-4447
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.92.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Fix For: 0.92.0
>
> Attachments: HBASE-4447-0.92.patch
>
>
> Currently the build always produces the jars and tarball according to the version baked into the POM.
> When we modify this to allow the version to be passed in as a command-line argument, it can still default to the same behavior, yet give the flexibility for an internal build to tag on own version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4447) Allow hbase.version to be passed in
as command-line argument
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108439#comment-13108439 ]
Hudson commented on HBASE-4447:
-------------------------------
Integrated in HBase-TRUNK #2238 (See [https://builds.apache.org/job/HBase-TRUNK/2238/])
HBASE-4447 Allow hbase.version to be passed in as command-line argument
stack :
Files :
* /hbase/trunk/pom.xml
> Allow hbase.version to be passed in as command-line argument
> ------------------------------------------------------------
>
> Key: HBASE-4447
> URL: https://issues.apache.org/jira/browse/HBASE-4447
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.92.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Fix For: 0.92.0
>
> Attachments: HBASE-4447-0.92.patch
>
>
> Currently the build always produces the jars and tarball according to the version baked into the POM.
> When we modify this to allow the version to be passed in as a command-line argument, it can still default to the same behavior, yet give the flexibility for an internal build to tag on own version.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4447) Allow hbase.version to be passed in
as command-line argument
Posted by "Joep Rottinghuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joep Rottinghuis updated HBASE-4447:
------------------------------------
Attachment: HBASE-4447-0.92.patch
Patch for 0.92 branch. Will add one for trunk soon.
> Allow hbase.version to be passed in as command-line argument
> ------------------------------------------------------------
>
> Key: HBASE-4447
> URL: https://issues.apache.org/jira/browse/HBASE-4447
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.92.0
> Reporter: Joep Rottinghuis
> Attachments: HBASE-4447-0.92.patch
>
>
> Currently the build always produces the jars and tarball according to the version baked into the POM.
> When we modify this to allow the version to be passed in as a command-line argument, it can still default to the same behavior, yet give the flexibility for an internal build to tag on own version.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4447) Allow hbase.version to be passed in
as command-line argument
Posted by "Joep Rottinghuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108364#comment-13108364 ]
Joep Rottinghuis commented on HBASE-4447:
-----------------------------------------
Actually, you'll want to leave off the hadoop.version override:
mvn install -DskipTests=true -Dhadoop.profile=22 -Dhbase.version=0.92-joep.0 > build.log
Same will work when leaving the hadoop.profile alone.
> Allow hbase.version to be passed in as command-line argument
> ------------------------------------------------------------
>
> Key: HBASE-4447
> URL: https://issues.apache.org/jira/browse/HBASE-4447
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.92.0
> Reporter: Joep Rottinghuis
> Attachments: HBASE-4447-0.92.patch
>
>
> Currently the build always produces the jars and tarball according to the version baked into the POM.
> When we modify this to allow the version to be passed in as a command-line argument, it can still default to the same behavior, yet give the flexibility for an internal build to tag on own version.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4447) Allow hbase.version to be passed in
as command-line argument
Posted by "Eric Yang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120344#comment-13120344 ]
Eric Yang commented on HBASE-4447:
----------------------------------
Maven requires fixed <version> number, or the maven repository will be tainted with ${hbase.version} instead of 0.92.x. The proper method to control version number is to use Versions Maven Plugin. see:
http://mojo.codehaus.org/versions-maven-plugin/
This patch should be reverted.
> Allow hbase.version to be passed in as command-line argument
> ------------------------------------------------------------
>
> Key: HBASE-4447
> URL: https://issues.apache.org/jira/browse/HBASE-4447
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.92.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Fix For: 0.92.0
>
> Attachments: HBASE-4447-0.92.patch
>
>
> Currently the build always produces the jars and tarball according to the version baked into the POM.
> When we modify this to allow the version to be passed in as a command-line argument, it can still default to the same behavior, yet give the flexibility for an internal build to tag on own version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4447) Allow hbase.version to be passed in
as command-line argument
Posted by "stack (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-4447.
--------------------------
Resolution: Fixed
I reverted this change. Closing.
> Allow hbase.version to be passed in as command-line argument
> ------------------------------------------------------------
>
> Key: HBASE-4447
> URL: https://issues.apache.org/jira/browse/HBASE-4447
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.92.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Fix For: 0.92.0
>
> Attachments: HBASE-4447-0.92.patch
>
>
> Currently the build always produces the jars and tarball according to the version baked into the POM.
> When we modify this to allow the version to be passed in as a command-line argument, it can still default to the same behavior, yet give the flexibility for an internal build to tag on own version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4447) Allow hbase.version to be passed in
as command-line argument
Posted by "Joep Rottinghuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108366#comment-13108366 ]
Joep Rottinghuis commented on HBASE-4447:
-----------------------------------------
Just picked hbase.version to keep symmetric with avro.version, hadoop.version, etc.
I see your point on project.version.
It's all the same to me. Which do you prefer?
Pls let me know before I crank out the patch for trunk.
Thanks,
Joep
-----Original Message-----
From: Jesse Yates [mailto:jesse.k.yates@gmail.com]
Sent: Monday, September 19, 2011 9:26 PM
To: dev@hbase.apache.org
Subject: Re: Branching for 0.92 [WAS -> Re: [DISCUSSION] Accumulo, another BigTable clone, has shown up on Apache Incubator as a proposal]
Yeah, that works too. Generally, I think people go with project.version, but it doesn't really matter ;)
-Jesse
On Mon, Sep 19, 2011 at 9:22 PM, Rottinghuis, Joep <jr...@ebay.com>wrote:
> Just filed a jira with patch for this. See HBASE-4447.
>
> Thanks,
>
> Joep
>
> -----Original Message-----
> From: saint.ack@gmail.com [mailto:saint.ack@gmail.com] On Behalf Of
> Stack
> Sent: Monday, September 19, 2011 9:21 PM
> To: dev@hbase.apache.org
> Subject: Re: Branching for 0.92 [WAS -> Re: [DISCUSSION] Accumulo,
> another BigTable clone, has shown up on Apache Incubator as a
> proposal]
>
> On Mon, Sep 19, 2011 at 8:53 PM, Jesse Yates <je...@gmail.com>
> wrote:
> > You should be able to pretty easily set in in the pom (under
> > properties), and then just use in the <version> tag.
> >
>
> Where are the pom properties Jesse?
> Thanks,
> St.Ack
> Allow hbase.version to be passed in as command-line argument
> ------------------------------------------------------------
>
> Key: HBASE-4447
> URL: https://issues.apache.org/jira/browse/HBASE-4447
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.92.0
> Reporter: Joep Rottinghuis
> Attachments: HBASE-4447-0.92.patch
>
>
> Currently the build always produces the jars and tarball according to the version baked into the POM.
> When we modify this to allow the version to be passed in as a command-line argument, it can still default to the same behavior, yet give the flexibility for an internal build to tag on own version.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HBASE-4447) Allow hbase.version to be passed in
as command-line argument
Posted by "Eric Yang (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Yang reopened HBASE-4447:
------------------------------
> Allow hbase.version to be passed in as command-line argument
> ------------------------------------------------------------
>
> Key: HBASE-4447
> URL: https://issues.apache.org/jira/browse/HBASE-4447
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.92.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Fix For: 0.92.0
>
> Attachments: HBASE-4447-0.92.patch
>
>
> Currently the build always produces the jars and tarball according to the version baked into the POM.
> When we modify this to allow the version to be passed in as a command-line argument, it can still default to the same behavior, yet give the flexibility for an internal build to tag on own version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4447) Allow hbase.version to be passed in
as command-line argument
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133789#comment-13133789 ]
Hudson commented on HBASE-4447:
-------------------------------
Integrated in HBase-TRUNK #2360 (See [https://builds.apache.org/job/HBase-TRUNK/2360/])
HBASE-4447 Allow hbase.version to be passed in as command-line argument; REVERTsvn diffsvn diff
stack :
Files :
* /hbase/trunk/pom.xml
> Allow hbase.version to be passed in as command-line argument
> ------------------------------------------------------------
>
> Key: HBASE-4447
> URL: https://issues.apache.org/jira/browse/HBASE-4447
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.92.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Fix For: 0.92.0
>
> Attachments: HBASE-4447-0.92.patch
>
>
> Currently the build always produces the jars and tarball according to the version baked into the POM.
> When we modify this to allow the version to be passed in as a command-line argument, it can still default to the same behavior, yet give the flexibility for an internal build to tag on own version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira