You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2021/08/07 12:39:16 UTC
[commons-math] 01/02: MATH-1573 - Redundant local variable
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-math.git
commit 3aab6312722297daddc34e5f5de9a0762d040563
Author: Arturo Bernal <ar...@gmail.com>
AuthorDate: Fri Aug 6 07:38:21 2021 +0200
MATH-1573 - Redundant local variable
---
.../org/apache/commons/math4/legacy/core/jdkmath/AccurateMath.java | 4 +---
.../commons/math4/legacy/analysis/differentiation/SparseGradient.java | 3 +--
.../interpolation/PiecewiseBicubicSplineInterpolatingFunction.java | 4 +---
.../java/org/apache/commons/math4/legacy/genetics/BinaryMutation.java | 3 +--
.../commons/math4/legacy/optim/nonlinear/scalar/LineSearch.java | 3 +--
.../commons/math4/legacy/stat/inference/KolmogorovSmirnovTest.java | 4 +---
6 files changed, 6 insertions(+), 15 deletions(-)
diff --git a/commons-math-legacy-core/src/main/java/org/apache/commons/math4/legacy/core/jdkmath/AccurateMath.java b/commons-math-legacy-core/src/main/java/org/apache/commons/math4/legacy/core/jdkmath/AccurateMath.java
index cf86c93..a65b3c7 100644
--- a/commons-math-legacy-core/src/main/java/org/apache/commons/math4/legacy/core/jdkmath/AccurateMath.java
+++ b/commons-math-legacy-core/src/main/java/org/apache/commons/math4/legacy/core/jdkmath/AccurateMath.java
@@ -2792,9 +2792,7 @@ public final class AccurateMath {
}
// Call atan
- final double result = atan(ra, rb, x < 0);
-
- return result;
+ return atan(ra, rb, x < 0);
}
/** Compute the arc sine of a number.
diff --git a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/differentiation/SparseGradient.java b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/differentiation/SparseGradient.java
index 035ac36..7e71c6d 100644
--- a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/differentiation/SparseGradient.java
+++ b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/differentiation/SparseGradient.java
@@ -178,8 +178,7 @@ public final class SparseGradient implements RealFieldElement<SparseGradient>, S
/** {@inheritDoc} */
@Override
public SparseGradient add(final double c) {
- final SparseGradient out = new SparseGradient(value + c, derivatives);
- return out;
+ return new SparseGradient(value + c, derivatives);
}
/** {@inheritDoc} */
diff --git a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/interpolation/PiecewiseBicubicSplineInterpolatingFunction.java b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/interpolation/PiecewiseBicubicSplineInterpolatingFunction.java
index 587310d..941dd68 100644
--- a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/interpolation/PiecewiseBicubicSplineInterpolatingFunction.java
+++ b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/analysis/interpolation/PiecewiseBicubicSplineInterpolatingFunction.java
@@ -142,9 +142,7 @@ public class PiecewiseBicubicSplineInterpolatingFunction
final PolynomialSplineFunction spline = interpolator.interpolate(yArray, interpArray);
- double returnValue = spline.value(y);
-
- return returnValue;
+ return spline.value(y);
}
/**
diff --git a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/genetics/BinaryMutation.java b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/genetics/BinaryMutation.java
index d3f6a23..ce23471 100644
--- a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/genetics/BinaryMutation.java
+++ b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/genetics/BinaryMutation.java
@@ -50,8 +50,7 @@ public class BinaryMutation implements MutationPolicy {
// and change it
newRepr.set(geneIndex, origChrom.getRepresentation().get(geneIndex) == 0 ? 1 : 0);
- Chromosome newChrom = origChrom.newFixedLengthChromosome(newRepr);
- return newChrom;
+ return origChrom.newFixedLengthChromosome(newRepr);
}
}
diff --git a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/LineSearch.java b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/LineSearch.java
index 4622df4..1dab365 100644
--- a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/LineSearch.java
+++ b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/LineSearch.java
@@ -119,8 +119,7 @@ public class LineSearch {
for (int i = 0; i < n; i++) {
x[i] = startPoint[i] + alpha * direction[i];
}
- final double obj = mainOptimizer.computeObjectiveValue(x);
- return obj;
+ return mainOptimizer.computeObjectiveValue(x);
}
};
diff --git a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/inference/KolmogorovSmirnovTest.java b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/inference/KolmogorovSmirnovTest.java
index 44cb2c6..741b4ca 100644
--- a/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/inference/KolmogorovSmirnovTest.java
+++ b/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/stat/inference/KolmogorovSmirnovTest.java
@@ -961,9 +961,7 @@ public class KolmogorovSmirnovTest {
* \(D_{n,m}\) greater than {@code d}
*/
public double approximateP(double d, int n, int m) {
- final double dm = m;
- final double dn = n;
- return 1 - ksSum(d * AccurateMath.sqrt((dm * dn) / (dm + dn)),
+ return 1 - ksSum(d * AccurateMath.sqrt(((double) m * (double) n) / ((double) m + (double) n)),
KS_SUM_CAUCHY_CRITERION, MAXIMUM_PARTIAL_SUM_COUNT);
}