[GitHub] [incubator-superset] michellethomas opened a new pull request #7468: [WIP] Adding controls for verifying options

[GitBox <gi...@apache.org>]

michellethomas opened a new pull request #7468: [WIP] Adding controls for verifying options
URL: https://github.com/apache/incubator-superset/pull/7468
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   We have a large table where not all combinations of values are applicable and we need to have a step that calls an endpoint to verify the dimensions and metrics included in the groupby, filter, and metrics controls. I'm trying to evaluate this as a possible option for doing that. This creates a withVerification HOC that verifies options before passing them to the resulting control. 
   
   I'll add tests to this, just wanted to get some early eyes to see if this seems like a viable solution.
   
   ### TEST PLAN
   Use controlOverrides to set this control for certain chart types
   Also in controlOverrides: 
   
   - Pass it a getEndpoint function that builds an endpoint from the controlValues
   - Set control values in a customized mapStateToProps 
   
   Check to make sure validation is working
   Check to make sure normal options are present (no validation) when there's no getEndpoint
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org