Re: [PR] HDDS-10557. TestBlockOutputStream#testWriteExactlyFlushSize is flaky [ozone]

["chungen0126 (via GitHub)" <gi...@apache.org>]

chungen0126 commented on code in PR #6573:
URL: https://github.com/apache/ozone/pull/6573#discussion_r1580610084


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockOutputStream.java:
##########
@@ -305,24 +305,24 @@ void testWriteExactlyFlushSize(boolean flushDelay) throws Exception {
       assertEquals(1, keyOutputStream.getStreamEntries().size());
       // The previously written data is equal to flushSize, so no action is
       // triggered when execute flush, if flushDelay is enabled.
-      assertEquals(pendingWriteChunkCount + (flushDelay ? 2 : 0),
-          metrics.getPendingContainerOpCountMetrics(WriteChunk));
-      assertEquals(pendingPutBlockCount + (flushDelay ? 1 : 0),
-          metrics.getPendingContainerOpCountMetrics(PutBlock));
+      if (!flushDelay) {

Review Comment:
   After check, `assertEquals(0, blockOutputStream.getBufferPool().computeBufferData());
           assertEquals(dataLength, blockOutputStream.getTotalAckDataLength());` these two assertions don't need to be changed.
   And I add some description explaining why those pendingContainerOp assersions should be changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org