[jira] [Commented] (HADOOP-10172) Cache SASL server factories

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850886#comment-13850886 ] 

Hadoop QA commented on HADOOP-10172:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12619149/HADOOP-10172.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3365//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3365//console

This message is automatically generated.

> Cache SASL server factories
> ---------------------------
>
>                 Key: HADOOP-10172
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10172
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>            Priority: Critical
>         Attachments: HADOOP-10172.patch
>
>
> Performance for SASL server creation is _atrocious_.  {{Sasl.createSaslServer}} does not cache the provider resolution for the factories.  Factory resolution and server instantiation has 3 major contention points.  During bursts of connections, one reader accepting a connection stalls other readers accepting connections, in turn stalling all existing connections handled by those readers.
> I benched 5 threads at 187 instances/s - total, not per thread.  With this and another change, I've boosted it to 33K instances/s.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)