Re: [PR] Adding Code Coverage webserver code and Fix TypeError and AttributeError in Views.py [airflow]

["aritra24 (via GitHub)" <gi...@apache.org>]

aritra24 commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1684610001


##########
tests/www/views/test_views_tasks.py:
##########
@@ -66,7 +66,7 @@ def reset_dagruns():
 
 
 @pytest.fixture(autouse=True)
-def init_dagruns(app, reset_dagruns):

Review Comment:
   What was this used for? 



##########
tests/models/test_xcom_arg_map.py:
##########
@@ -188,6 +191,44 @@ def does_not_work_with_c(v):
     ]
 
 
+def test_task_map_from_task_instance_xcom():

Review Comment:
   Mostly for my understanding how is this related to xcom? Also perhaps the two cases should be two different test cases one a success and one fail but mostly a nit. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org