You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by ericcarlschwartz <gi...@git.apache.org> on 2016/09/01 18:45:28 UTC
[GitHub] trafficserver pull request #954: [TS-4457] Via header always reports http1
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/954
[TS-4457] Via header always reports http1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ericcarlschwartz/trafficserver TS-4457
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/954.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #954
----
commit c40d2733886a8e2c3613660894b2d4fbae2cee79
Author: ericcarlschwartz <es...@gmail.com>
Date: 2016-08-31T22:42:44Z
[TS-4457] Via header always reports http1
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #954: [TS-4457] Via header always reports http1
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/954
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/663/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #954: [TS-4457] Via header always reports http1
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/954
@ericcarlschwartz It failed because of clang-format :-).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #954: [TS-4457] Via header always reports http1
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/954
Why can't you just slam in the result of ``get_protocol_string()`` in all cases?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #954: [TS-4457] Via header always reports http1
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/954
\U0001f44d - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #954: [TS-4457] Via header always reports http1
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/954
You might want to leverage the populate_protocol() functions added for TS-4703 to create the protocol-specific via string.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #954: [TS-4457] Via header always reports http1
Posted by ericcarlschwartz <gi...@git.apache.org>.
Github user ericcarlschwartz commented on the issue:
https://github.com/apache/trafficserver/pull/954
@shinrich thanks for that info! That's definitely an interesting and useful way to do this using existing code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #954: [TS-4457] Via header always reports http1
Posted by ericcarlschwartz <gi...@git.apache.org>.
Github user ericcarlschwartz commented on the issue:
https://github.com/apache/trafficserver/pull/954
@jpeach get_protocol_string() for http1.1/1.0 will just return "http". We could use that and then append the major/minor versions to that but I thought keeping the existing code would be clearer/minimize the difference for how it's done for the incoming request
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #954: [TS-4457] Via header always reports http1
Posted by ericcarlschwartz <gi...@git.apache.org>.
Github user ericcarlschwartz commented on the issue:
https://github.com/apache/trafficserver/pull/954
aaaah sorry this is bad i'm going to close it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #954: [TS-4457] Via header always reports http1
Posted by ericcarlschwartz <gi...@git.apache.org>.
Github user ericcarlschwartz closed the pull request at:
https://github.com/apache/trafficserver/pull/954
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #954: [TS-4457] Via header always reports http1
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/954
@ericcarlschwartz
```C++
- if (s->state_machine->ua_session && (!strncmp(s->state_machine->ua_session->get_protocol_string(), "http/2", 6))) { //if http/2
+ if (s->state_machine->ua_session && (!strncmp(s->state_machine->ua_session->get_protocol_string(), "http/2", 6))) { // if http/2
memcpy(via_string, "http/2 ", 7);
via_string += 7;
- } else { //if http/1.1 or older
+ } else { // if http/1.1 or older
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #954: [TS-4457] Via header always reports http1
Posted by ericcarlschwartz <gi...@git.apache.org>.
Github user ericcarlschwartz commented on the issue:
https://github.com/apache/trafficserver/pull/954
per IRC discussion on 9/1 looks like we want to rework this to rely entirely on result from get_protocol_string? Also @bryancall suggested maybe adding TLS info? How do others feel about that? Pretty sure we could do that with an old change from acacio
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #954: [TS-4457] Via header always reports http1
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/954
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/558/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #954: [TS-4457] Via header always reports http1
Posted by ericcarlschwartz <gi...@git.apache.org>.
Github user ericcarlschwartz commented on the issue:
https://github.com/apache/trafficserver/pull/954
A bit confused why the linux build here croaked and the FreeBSD one succeeded?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #954: [TS-4457] Via header always reports http1
Posted by ericcarlschwartz <gi...@git.apache.org>.
Github user ericcarlschwartz commented on the issue:
https://github.com/apache/trafficserver/pull/954
@zwoop ah sorry! I must be doing something wrong, when I ran clang format on it just now I didn't get any changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #954: [TS-4457] Via header always reports http1
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/954
Hmmm, not sure. But if you look at the link, it clearly didn't like those lines.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---