You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/08/01 14:53:03 UTC
Review Request 68141: Moved Framework implementation into separate
file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-2633
https://issues.apache.org/jira/browse/MESOS-2633
Repository: mesos
Description
-------
Moved Framework implementation into separate file.
Diffs
-----
src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5
src/Makefile.am 71f9052f60fc65d8183faa7ab9764d3e6388ddc9
src/master/framework.cpp PRE-CREATION
src/master/master.hpp 0353d550308816f219aedb6afe15c643fc8bb340
Diff: https://reviews.apache.org/r/68141/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68141: Moved Framework implementation into
separate file.
Posted by Benno Evers <be...@mesosphere.com>.
> On Aug. 2, 2018, 10:33 a.m., Alexander Rukletsov wrote:
> > src/master/master.hpp
> > Lines 2981-2983 (original)
> > <https://reviews.apache.org/r/68141/diff/2/?file=2066246#file2066246line2981>
> >
> > I think these qualify to stay in ".hpp".
Letting functions stay in header files can of course be good for inlining, but there are advantages to moving even "small" functions to separate object files:
- it makes the function easier to grep for since one can use `Framework::active` as pattern
- it makes it easier to find the function when it is defined in the same file as all the other functions
- it removes subjectivity about when a function is "simple enough" to be defined inline from subsequent reviews
I moved them back to the `.hpp` in the subsequent review, but I changed them to be out-of-class definitions due to reasons (1) and (3) above.
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/#review206788
-----------------------------------------------------------
On Aug. 2, 2018, 12:17 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68141/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2018, 12:17 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-2633
> https://issues.apache.org/jira/browse/MESOS-2633
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change aims to reduce compile time and cognitive
> load when browsing the "master.hpp" header.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e
> src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66
> src/master/framework.cpp PRE-CREATION
> src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116
> src/master/master.cpp 192fe8299777f68bf6f48d693ef79ff75fecfe00
>
>
> Diff: https://reviews.apache.org/r/68141/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68141: Moved Framework implementation into
separate file.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/#review206788
-----------------------------------------------------------
src/master/master.hpp
Lines 2981-2983 (original)
<https://reviews.apache.org/r/68141/#comment289870>
I think these qualify to stay in ".hpp".
src/master/master.hpp
Lines 2985-2987 (original), 2449-2451 (patched)
<https://reviews.apache.org/r/68141/#comment289869>
Can you please move all `Framework::*` definitions from "master.cpp" to "framework.cpp"?
- Alexander Rukletsov
On Aug. 2, 2018, 10:26 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68141/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2018, 10:26 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-2633
> https://issues.apache.org/jira/browse/MESOS-2633
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change aims to reduce compile time and cognitive
> load when browsing the "master.hpp" header.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e
> src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66
> src/master/framework.cpp PRE-CREATION
> src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116
>
>
> Diff: https://reviews.apache.org/r/68141/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68141: Moved Framework implementation into
separate file.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/#review206799
-----------------------------------------------------------
src/Makefile.am
Lines 1021 (patched)
<https://reviews.apache.org/r/68141/#comment289878>
Please tabs in Makefile.
- Alexander Rukletsov
On Aug. 2, 2018, 1:23 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68141/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2018, 1:23 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-2633
> https://issues.apache.org/jira/browse/MESOS-2633
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change aims to reduce compile time and cognitive
> load when browsing the "master.hpp" header.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e
> src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66
> src/master/framework.cpp PRE-CREATION
> src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116
> src/master/master.cpp 192fe8299777f68bf6f48d693ef79ff75fecfe00
>
>
> Diff: https://reviews.apache.org/r/68141/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68141: Moved Framework implementation into
separate file.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/
-----------------------------------------------------------
(Updated Aug. 2, 2018, 1:23 p.m.)
Review request for mesos and Alexander Rukletsov.
Changes
-------
Re-uploaded commits to investigate failure to apply patches.
Bugs: MESOS-2633
https://issues.apache.org/jira/browse/MESOS-2633
Repository: mesos
Description
-------
This change aims to reduce compile time and cognitive
load when browsing the "master.hpp" header.
Diffs (updated)
-----
src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e
src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66
src/master/framework.cpp PRE-CREATION
src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116
src/master/master.cpp 192fe8299777f68bf6f48d693ef79ff75fecfe00
Diff: https://reviews.apache.org/r/68141/diff/4/
Changes: https://reviews.apache.org/r/68141/diff/3-4/
Testing
-------
`make check`
Thanks,
Benno Evers
Re: Review Request 68141: Moved Framework implementation into
separate file.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/#review206797
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Aug. 2, 2018, 12:17 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68141/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2018, 12:17 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-2633
> https://issues.apache.org/jira/browse/MESOS-2633
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change aims to reduce compile time and cognitive
> load when browsing the "master.hpp" header.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e
> src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66
> src/master/framework.cpp PRE-CREATION
> src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116
> src/master/master.cpp 192fe8299777f68bf6f48d693ef79ff75fecfe00
>
>
> Diff: https://reviews.apache.org/r/68141/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68141: Moved Framework implementation into
separate file.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/
-----------------------------------------------------------
(Updated Aug. 2, 2018, 12:17 p.m.)
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-2633
https://issues.apache.org/jira/browse/MESOS-2633
Repository: mesos
Description
-------
This change aims to reduce compile time and cognitive
load when browsing the "master.hpp" header.
Diffs (updated)
-----
src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e
src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66
src/master/framework.cpp PRE-CREATION
src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116
src/master/master.cpp 192fe8299777f68bf6f48d693ef79ff75fecfe00
Diff: https://reviews.apache.org/r/68141/diff/3/
Changes: https://reviews.apache.org/r/68141/diff/2-3/
Testing
-------
`make check`
Thanks,
Benno Evers
Re: Review Request 68141: Moved Framework implementation into
separate file.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/#review206794
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68141']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2030/mesos-review-68141
Relevant logs:
- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2030/mesos-review-68141/logs/mesos-tests-cmake-stdout.log):
```
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500): warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479): warning C4101: 'addrstr': unreferenced local variable [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170): warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (17) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\src\master\framework.cpp(698): error C2512: 'mesos::internal::master::FrameworkMetrics': no appropriate default constructor available [D:\DCOS\mesos\src\mesos.vcxproj]
172 Warning(s)
1 Error(s)
Time Elapsed 00:11:22.45
```
- Mesos Reviewbot Windows
On Aug. 2, 2018, 10:26 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68141/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2018, 10:26 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-2633
> https://issues.apache.org/jira/browse/MESOS-2633
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change aims to reduce compile time and cognitive
> load when browsing the "master.hpp" header.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e
> src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66
> src/master/framework.cpp PRE-CREATION
> src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116
>
>
> Diff: https://reviews.apache.org/r/68141/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68141: Moved Framework implementation into
separate file.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/
-----------------------------------------------------------
(Updated Aug. 2, 2018, 10:26 a.m.)
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-2633
https://issues.apache.org/jira/browse/MESOS-2633
Repository: mesos
Description (updated)
-------
This change aims to reduce compile time and cognitive
load when browsing the "master.hpp" header.
Diffs
-----
src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e
src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66
src/master/framework.cpp PRE-CREATION
src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116
Diff: https://reviews.apache.org/r/68141/diff/2/
Testing
-------
`make check`
Thanks,
Benno Evers
Re: Review Request 68141: Moved Framework implementation into
separate file.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/
-----------------------------------------------------------
(Updated Aug. 2, 2018, 10:18 a.m.)
Review request for mesos and Alexander Rukletsov.
Changes
-------
Rebased onto master.
Bugs: MESOS-2633
https://issues.apache.org/jira/browse/MESOS-2633
Repository: mesos
Description (updated)
-------
Moved Framework implementation into separate file.
This change should hopefully reduce compile times and reduce cognitive load when browsing through through the `master.hpp` header.
Diffs (updated)
-----
src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e
src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66
src/master/framework.cpp PRE-CREATION
src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116
Diff: https://reviews.apache.org/r/68141/diff/2/
Changes: https://reviews.apache.org/r/68141/diff/1-2/
Testing (updated)
-------
`make check`
Thanks,
Benno Evers
Re: Review Request 68141: Moved Framework implementation into
separate file.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/#review206748
-----------------------------------------------------------
PASS: Mesos patch 68141 was successfully built and tested.
Reviews applied: `['68141']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2020/mesos-review-68141
- Mesos Reviewbot Windows
On Aug. 1, 2018, 7:53 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68141/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2018, 7:53 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-2633
> https://issues.apache.org/jira/browse/MESOS-2633
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved Framework implementation into separate file.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5
> src/Makefile.am 71f9052f60fc65d8183faa7ab9764d3e6388ddc9
> src/master/framework.cpp PRE-CREATION
> src/master/master.hpp 0353d550308816f219aedb6afe15c643fc8bb340
>
>
> Diff: https://reviews.apache.org/r/68141/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>