You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2014/06/09 23:39:27 UTC
Review Request 22400: [HELIX-440] One-time scheduling for task framework
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22400/
-----------------------------------------------------------
Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
Bugs: HELIX-440
Repository: helix-git
Description
-------
commit ef616806573eae94c00a627d980e0709251c4278
Author: Kanak Biscuitwala <ka...@apache.org>
Date: Thu Jun 5 09:37:31 2014 -0700
[HELIX-440] One-time scheduling for task framework
:000000 100644 0000000... 82d1a22... A helix-core/src/main/java/org/apache/helix/task/ScheduleConfig.java
:100644 100644 a6244c8... dc0eb33... M helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java
:100644 100644 a5c97ac... a5fc026... M helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
:100644 100644 57404d8... 7e54347... M helix-core/src/main/java/org/apache/helix/task/Workflow.java
:100644 100644 6f10955... b3e30ae... M helix-core/src/main/java/org/apache/helix/task/WorkflowConfig.java
:000000 100644 0000000... 9e843f5... A helix-core/src/main/java/org/apache/helix/task/beans/ScheduleBean.java
:100644 100644 76da4c8... 2ea23c7... M helix-core/src/main/java/org/apache/helix/task/beans/WorkflowBean.java
:100644 100644 10f0ac7... b5856b1... M helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java
Diffs
-----
helix-core/src/main/java/org/apache/helix/task/ScheduleConfig.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java a6244c8
helix-core/src/main/java/org/apache/helix/task/TaskUtil.java a5c97ac
helix-core/src/main/java/org/apache/helix/task/Workflow.java 57404d8
helix-core/src/main/java/org/apache/helix/task/WorkflowConfig.java 6f10955
helix-core/src/main/java/org/apache/helix/task/beans/ScheduleBean.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/task/beans/WorkflowBean.java 76da4c8
helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java 10f0ac7
Diff: https://reviews.apache.org/r/22400/diff/
Testing
-------
Created a test case to ensure that a one-shot scheduled event actually waited for the right time to start.
Thanks,
Kanak Biscuitwala
Re: Review Request 22400: [HELIX-440] One-time scheduling for task framework
Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22400/#review45533
-----------------------------------------------------------
Ship it!
Ship It!
- Zhen Zhang
On June 9, 2014, 9:39 p.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22400/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 9:39 p.m.)
>
>
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
>
>
> Bugs: HELIX-440
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit ef616806573eae94c00a627d980e0709251c4278
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date: Thu Jun 5 09:37:31 2014 -0700
>
> [HELIX-440] One-time scheduling for task framework
>
> :000000 100644 0000000... 82d1a22... A helix-core/src/main/java/org/apache/helix/task/ScheduleConfig.java
> :100644 100644 a6244c8... dc0eb33... M helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java
> :100644 100644 a5c97ac... a5fc026... M helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
> :100644 100644 57404d8... 7e54347... M helix-core/src/main/java/org/apache/helix/task/Workflow.java
> :100644 100644 6f10955... b3e30ae... M helix-core/src/main/java/org/apache/helix/task/WorkflowConfig.java
> :000000 100644 0000000... 9e843f5... A helix-core/src/main/java/org/apache/helix/task/beans/ScheduleBean.java
> :100644 100644 76da4c8... 2ea23c7... M helix-core/src/main/java/org/apache/helix/task/beans/WorkflowBean.java
> :100644 100644 10f0ac7... b5856b1... M helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/task/ScheduleConfig.java PRE-CREATION
> helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java a6244c8
> helix-core/src/main/java/org/apache/helix/task/TaskUtil.java a5c97ac
> helix-core/src/main/java/org/apache/helix/task/Workflow.java 57404d8
> helix-core/src/main/java/org/apache/helix/task/WorkflowConfig.java 6f10955
> helix-core/src/main/java/org/apache/helix/task/beans/ScheduleBean.java PRE-CREATION
> helix-core/src/main/java/org/apache/helix/task/beans/WorkflowBean.java 76da4c8
> helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java 10f0ac7
>
> Diff: https://reviews.apache.org/r/22400/diff/
>
>
> Testing
> -------
>
> Created a test case to ensure that a one-shot scheduled event actually waited for the right time to start.
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>