You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "michael herndon (JIRA)" <ji...@apache.org> on 2011/07/13 19:12:59 UTC

[Lucene.Net] [jira] [Created] (LUCENENET-436) Refactor Deprecated Code inside of tests

Refactor Deprecated Code inside of tests 
-----------------------------------------

                 Key: LUCENENET-436
                 URL: https://issues.apache.org/jira/browse/LUCENENET-436
             Project: Lucene.Net
          Issue Type: Sub-task
          Components: Lucene.Net Test
    Affects Versions: Lucene.Net 2.9.4g
            Reporter: michael herndon


* We should still be testing deprecated methods, but we need to use #pragma warning disable/enable 0618 for testing those. otherwise compiler warnings are too numerous to be anywhere near helpful.
* We should only be using deprecated methods in places where they are being explicitly tested, other tests that need that functionality in 
order to validate those tests should be re factored to use methods that are not deprecated.

This is one place we should probably deviate from the parent project and make sure that any deprecated code gets isolated to the tests designed only for the deprecated methods and then use the newer API through out the testsuite.

This should help move the project forward and remove deprecated API's when the time comes.   

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Lucene.Net] [jira] [Updated] (LUCENENET-436) Refactor Deprecated Code inside of tests

Posted by "Christopher Currens (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENENET-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christopher Currens updated LUCENENET-436:
------------------------------------------

    Fix Version/s: Lucene.Net 3.0.3

This is a nice to have for the 3.x release.  A lot of the tests are written with deprecated code simply, because they are that way in Java Lucene, and thus haven't been updated.  Unless the majority objects, I agree that we should take this approach of removing the deprecated code ourselves, when the test isn't testing the behavior of the deprecated method itself, instead of sticking to exact Java tests.

I say we try and get as much of it as we can updated, but not have this issue block a 3.x release if we run out of time.
                
> Refactor Deprecated Code inside of tests 
> -----------------------------------------
>
>                 Key: LUCENENET-436
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-436
>             Project: Lucene.Net
>          Issue Type: Sub-task
>          Components: Lucene.Net Test
>    Affects Versions: Lucene.Net 2.9.4g
>            Reporter: michael herndon
>              Labels: refactoring, testing,
>             Fix For: Lucene.Net 3.0.3
>
>
> * We should still be testing deprecated methods, but we need to use #pragma warning disable/enable 0618 for testing those. otherwise compiler warnings are too numerous to be anywhere near helpful.
> * We should only be using deprecated methods in places where they are being explicitly tested, other tests that need that functionality in 
> order to validate those tests should be re factored to use methods that are not deprecated.
> This is one place we should probably deviate from the parent project and make sure that any deprecated code gets isolated to the tests designed only for the deprecated methods and then use the newer API through out the testsuite.
> This should help move the project forward and remove deprecated API's when the time comes.   

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (LUCENENET-436) Refactor Deprecated Code inside of tests

Posted by "Christopher Currens (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENENET-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christopher Currens updated LUCENENET-436:
------------------------------------------

    Affects Version/s: Lucene.Net 3.0.3
        Fix Version/s:     (was: Lucene.Net 3.0.3)
                       Lucene.Net 3.5
    
> Refactor Deprecated Code inside of tests 
> -----------------------------------------
>
>                 Key: LUCENENET-436
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-436
>             Project: Lucene.Net
>          Issue Type: Sub-task
>          Components: Lucene.Net Test
>    Affects Versions: Lucene.Net 2.9.4g, Lucene.Net 3.0.3
>            Reporter: michael herndon
>              Labels: refactoring, testing,
>             Fix For: Lucene.Net 3.5
>
>
> * We should still be testing deprecated methods, but we need to use #pragma warning disable/enable 0618 for testing those. otherwise compiler warnings are too numerous to be anywhere near helpful.
> * We should only be using deprecated methods in places where they are being explicitly tested, other tests that need that functionality in 
> order to validate those tests should be re factored to use methods that are not deprecated.
> This is one place we should probably deviate from the parent project and make sure that any deprecated code gets isolated to the tests designed only for the deprecated methods and then use the newer API through out the testsuite.
> This should help move the project forward and remove deprecated API's when the time comes.   

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira