You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/08 10:46:02 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #5420: server: allow listing custom offerings for a running VM
shwstppr opened a new pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420
### Description
`listServiceOffering` API when called for a running VM only fails to list all possible offerings especially the custom offerings and all offerings when VM is deployed using a custom offering.
This PR improves the list behviour by adding adding appropriate conditions for the custom offerings.
Fixes #5412
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
Offerings and VMs
```
(local) 🦐 > list serviceofferings filter=id,name,cpunumber,cpuspeed,memory,serviceofferingdetails
{
"count": 6,
"serviceoffering": [
{
"cpunumber": 1,
"cpuspeed": 500,
"id": "c17c21bb-faa4-4c14-9774-142260546670",
"memory": 512,
"name": "Small Instance"
},
{
"cpunumber": 1,
"cpuspeed": 1000,
"id": "0a785dc5-ff8d-48ed-82b2-e24cbd9587b9",
"memory": 1024,
"name": "Medium Instance"
},
{
"cpunumber": 1,
"cpuspeed": 1000,
"id": "3801bb99-4077-4685-919f-2ae51fce90a9",
"memory": 1536,
"name": "fixed"
},
{
"cpuspeed": 1000,
"id": "fe7de1af-b045-4749-a88f-c20a50082c7b",
"name": "Constrained",
"serviceofferingdetails": {
"maxcpunumber": "4",
"maxmemory": "2560",
"mincpunumber": "1",
"minmemory": "256"
}
},
{
"id": "3799cd94-8284-485e-81f0-bc3c1e6a29f9",
"name": "Unconstrained"
},
{
"cpuspeed": 1000,
"id": "b1423e9e-9fcf-48c1-b156-b563cf9bf4dd",
"name": "Constrained-1",
"serviceofferingdetails": {
"maxcpunumber": "4",
"maxmemory": "3072",
"mincpunumber": "2",
"minmemory": "512"
}
}
]
}
(local) 🦐 > list virtualmachines ids=112b9b4a-12e9-4cfc-8bd7-0e49eabb211f,00774881-64cf-45d1-8c9c-7bdaf7f195da filter=id,name,serviceofferingid,serviceofferingname,details,state
{
"count": 2,
"virtualmachine": [
{
"details": {
"cpuNumber": "2",
"memory": "1024"
},
"id": "00774881-64cf-45d1-8c9c-7bdaf7f195da",
"name": "t5",
"serviceofferingid": "fe7de1af-b045-4749-a88f-c20a50082c7b",
"serviceofferingname": "Constrained",
"state": "Running"
},
{
"details": {},
"id": "112b9b4a-12e9-4cfc-8bd7-0e49eabb211f",
"name": "t3",
"serviceofferingid": "c17c21bb-faa4-4c14-9774-142260546670",
"serviceofferingname": "Small Instance",
"state": "Running"
}
]
}
````
Before change:
```
(local) 🐣 > list serviceofferings filter=id,name,cpunumber,cpuspeed,memory,serviceofferingdetails virtualmachineid=112b9b4a-12e9-4cfc-8bd7-0e49eabb211f
{
"count": 2,
"serviceoffering": [
{
"cpunumber": 1,
"cpuspeed": 1000,
"id": "0a785dc5-ff8d-48ed-82b2-e24cbd9587b9",
"memory": 1024,
"name": "Medium Instance"
},
{
"cpunumber": 1,
"cpuspeed": 1000,
"id": "3801bb99-4077-4685-919f-2ae51fce90a9",
"memory": 1536,
"name": "fixed"
}
]
}
(local) 🐓 > list serviceofferings filter=id,name,cpunumber,cpuspeed,memory,serviceofferingdetails virtualmachineid=00774881-64cf-45d1-8c9c-7bdaf7f195da
```
After change:
```
(local) 🐕 > list serviceofferings filter=id,name,cpunumber,cpuspeed,memory,serviceofferingdetails virtualmachineid=112b9b4a-12e9-4cfc-8bd7-0e49eabb211f
{
"count": 5,
"serviceoffering": [
{
"cpunumber": 1,
"cpuspeed": 1000,
"id": "0a785dc5-ff8d-48ed-82b2-e24cbd9587b9",
"memory": 1024,
"name": "Medium Instance"
},
{
"cpunumber": 1,
"cpuspeed": 1000,
"id": "3801bb99-4077-4685-919f-2ae51fce90a9",
"memory": 1536,
"name": "fixed"
},
{
"cpuspeed": 1000,
"id": "fe7de1af-b045-4749-a88f-c20a50082c7b",
"name": "Constrained",
"serviceofferingdetails": {
"maxcpunumber": "4",
"maxmemory": "2560",
"mincpunumber": "1",
"minmemory": "256"
}
},
{
"id": "3799cd94-8284-485e-81f0-bc3c1e6a29f9",
"name": "Unconstrained"
},
{
"cpuspeed": 1000,
"id": "b1423e9e-9fcf-48c1-b156-b563cf9bf4dd",
"name": "Constrained-1",
"serviceofferingdetails": {
"maxcpunumber": "4",
"maxmemory": "3072",
"mincpunumber": "2",
"minmemory": "512"
}
}
]
}
(local) 🦑 > list serviceofferings filter=id,name,cpunumber,cpuspeed,memory,serviceofferingdetails virtualmachineid=00774881-64cf-45d1-8c9c-7bdaf7f195da
{
"count": 3,
"serviceoffering": [
{
"cpuspeed": 1000,
"id": "fe7de1af-b045-4749-a88f-c20a50082c7b",
"name": "Constrained",
"serviceofferingdetails": {
"maxcpunumber": "4",
"maxmemory": "2560",
"mincpunumber": "1",
"minmemory": "256"
}
},
{
"id": "3799cd94-8284-485e-81f0-bc3c1e6a29f9",
"name": "Unconstrained"
},
{
"cpuspeed": 1000,
"id": "b1423e9e-9fcf-48c1-b156-b563cf9bf4dd",
"name": "Constrained-1",
"serviceofferingdetails": {
"maxcpunumber": "4",
"maxmemory": "3072",
"mincpunumber": "2",
"minmemory": "512"
}
}
]
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-919874204
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-920559022
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-920612537
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-919911899
Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 1267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-920584676
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-915162490
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#discussion_r709791219
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -2994,9 +3034,28 @@
// 2.In case vm is running return only offerings greater than equal to current offering compute and offering's dynamic scalability should match
if (vmInstance.getState() == VirtualMachine.State.Running) {
- sc.addAnd("cpu", Op.GTEQ, currentVmOffering.getCpu());
- sc.addAnd("speed", Op.GTEQ, currentVmOffering.getSpeed());
- sc.addAnd("ramSize", Op.GTEQ, currentVmOffering.getRamSize());
+ Integer vmCpu = currentVmOffering.getCpu();
+ Integer vmMemory = currentVmOffering.getSpeed();
+ Integer vmSpeed = currentVmOffering.getSpeed();
+ if ((vmCpu == null || vmMemory == null || vmSpeed == null) && VirtualMachine.Type.User.equals(vmInstance.getType())) {
+ UserVmVO userVmVO = _userVmDao.findById(vmId);
+ _userVmDao.loadDetails(userVmVO);
+ Map<String, String> details = userVmVO.getDetails();
+ vmCpu = NumbersUtil.parseInt(details.get(ApiConstants.CPU_NUMBER), 0);
+ if (vmSpeed == null) {
+ vmSpeed = NumbersUtil.parseInt(details.get(ApiConstants.CPU_SPEED), 0);
+ }
+ vmMemory = NumbersUtil.parseInt(details.get(ApiConstants.MEMORY), 0);
+ }
+ if (vmCpu != null && vmCpu > 0) {
Review comment:
Not sure if that would add any benefit as that single SearchCriteria will also be a combination of these three SearchCriterias with AND condition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-920582546
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-921214871
Merging based on approvals and test results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr removed a comment on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-915769654
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-915769654
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#discussion_r709778565
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -2994,9 +3034,28 @@
// 2.In case vm is running return only offerings greater than equal to current offering compute and offering's dynamic scalability should match
if (vmInstance.getState() == VirtualMachine.State.Running) {
- sc.addAnd("cpu", Op.GTEQ, currentVmOffering.getCpu());
- sc.addAnd("speed", Op.GTEQ, currentVmOffering.getSpeed());
- sc.addAnd("ramSize", Op.GTEQ, currentVmOffering.getRamSize());
+ Integer vmCpu = currentVmOffering.getCpu();
+ Integer vmMemory = currentVmOffering.getSpeed();
+ Integer vmSpeed = currentVmOffering.getSpeed();
+ if ((vmCpu == null || vmMemory == null || vmSpeed == null) && VirtualMachine.Type.User.equals(vmInstance.getType())) {
+ UserVmVO userVmVO = _userVmDao.findById(vmId);
+ _userVmDao.loadDetails(userVmVO);
+ Map<String, String> details = userVmVO.getDetails();
+ vmCpu = NumbersUtil.parseInt(details.get(ApiConstants.CPU_NUMBER), 0);
+ if (vmSpeed == null) {
+ vmSpeed = NumbersUtil.parseInt(details.get(ApiConstants.CPU_SPEED), 0);
+ }
+ vmMemory = NumbersUtil.parseInt(details.get(ApiConstants.MEMORY), 0);
+ }
+ if (vmCpu != null && vmCpu > 0) {
Review comment:
Would it be better to have a single method to take cpu number, speed and memory and return a single sc instead ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-921140414
<b>Trillian test result (tid-2084)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41764 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5420-t2084-vmware-67u3.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-920558758
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-915126935
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-916308275
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-916619723
<b>Trillian test result (tid-2004)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35694 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5420-t2004-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-916306172
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-920585458
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-920593011
@rhtyd will restart tests as had to make a change
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-919875310
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-920593118
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-915127484
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#discussion_r709776694
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -2994,9 +3034,28 @@
// 2.In case vm is running return only offerings greater than equal to current offering compute and offering's dynamic scalability should match
if (vmInstance.getState() == VirtualMachine.State.Running) {
- sc.addAnd("cpu", Op.GTEQ, currentVmOffering.getCpu());
- sc.addAnd("speed", Op.GTEQ, currentVmOffering.getSpeed());
- sc.addAnd("ramSize", Op.GTEQ, currentVmOffering.getRamSize());
+ Integer vmCpu = currentVmOffering.getCpu();
+ Integer vmMemory = currentVmOffering.getSpeed();
Review comment:
```suggestion
Integer vmMemory = currentVmOffering.getRamSize();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-920614442
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-919853155
ping @shwstppr - can you fix the conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5420: server: allow listing custom offerings for a running VM
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5420:
URL: https://github.com/apache/cloudstack/pull/5420#issuecomment-920613256
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org