You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/02/04 19:34:39 UTC
Review Request 17714: Fixed flaky test
GroupTest.GroupWatchWithSessionExpiration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17714/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-965
https://issues.apache.org/jira/browse/MESOS-965
Repository: mesos-git
Description
-------
- This test became flaky due to a recent change in MESOS-935 that made Group update watchers in expired(), this introduced a race condition on the 'membership' variable. (Group thread sets it and the test thread reads it)
Diffs
-----
src/tests/group_tests.cpp 5d4240c5fb32db97a8a0920d90af5400a0900dfd
Diff: https://reviews.apache.org/r/17714/diff/
Testing
-------
Ran GroupTest.GroupWatchWithSessionExpiration for 500 iterations.
Thanks,
Jiang Yan Xu
Re: Review Request 17714: Fixed flaky test
GroupTest.GroupWatchWithSessionExpiration.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17714/
-----------------------------------------------------------
(Updated Feb. 4, 2014, 10:50 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Updated description. NNFR.
Bugs: MESOS-965
https://issues.apache.org/jira/browse/MESOS-965
Repository: mesos-git
Description (updated)
-------
- This test became flaky due to a recent change in MESOS-935 that made Group update watchers in expired(), this introduced a race condition on the 'membership.get().cancelled()' Future. (Group thread sets it and the test thread reads it)
Diffs
-----
src/tests/group_tests.cpp 5d4240c5fb32db97a8a0920d90af5400a0900dfd
Diff: https://reviews.apache.org/r/17714/diff/
Testing
-------
Ran GroupTest.GroupWatchWithSessionExpiration for 500 iterations.
Thanks,
Jiang Yan Xu
Re: Review Request 17714: Fixed flaky test
GroupTest.GroupWatchWithSessionExpiration.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17714/#review33621
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Feb. 4, 2014, 6:34 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17714/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2014, 6:34 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-965
> https://issues.apache.org/jira/browse/MESOS-965
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - This test became flaky due to a recent change in MESOS-935 that made Group update watchers in expired(), this introduced a race condition on the 'membership' variable. (Group thread sets it and the test thread reads it)
>
>
> Diffs
> -----
>
> src/tests/group_tests.cpp 5d4240c5fb32db97a8a0920d90af5400a0900dfd
>
> Diff: https://reviews.apache.org/r/17714/diff/
>
>
> Testing
> -------
>
> Ran GroupTest.GroupWatchWithSessionExpiration for 500 iterations.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>